[GitHub] [solr] bruno-roustant commented on a change in pull request #580: SOLR-15964: Transient cores: don't evict open ones

[GitBox <gi...@apache.org>]

bruno-roustant commented on a change in pull request #580:
URL: https://github.com/apache/solr/pull/580#discussion_r797064012



##########
File path: solr/core/src/java/org/apache/solr/core/TransientSolrCoreCacheDefault.java
##########
@@ -89,6 +86,21 @@ public TransientSolrCoreCacheDefault(CoreContainer coreContainer) {
     transientDescriptors = new LinkedHashMap<>(initialCapacity);
   }
 
+  private void onEvict(SolrCore core) {
+    if (core.getOpenCount() > 1) {

Review comment:
       @ben-manes is there a way to check this condition (core.getOpenCount() <= 1) during the selection of the entry to evict in Caffeine cache?
   Here we put back the evicted entry if this condition is not satisfied, potentially going beyond the max size defined, whereas there may be other potential entries to evict for which this condition is satisfied.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org