You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/12/08 08:45:06 UTC
[GitHub] [servicecomb-service-center] robotLJW opened a new pull request #1175: [feat] add eventbase
robotLJW opened a new pull request #1175:
URL: https://github.com/apache/servicecomb-service-center/pull/1175
1.add datasource in eventbase
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `go build` `go test` `go fmt` `go vet` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
- [ ] Never comment source code, delete it.
- [ ] UT should has "context, subject, expected result" result as test case name, when you call t.Run().
---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] little-cui merged pull request #1175: [feat] add eventbase
Posted by GitBox <gi...@apache.org>.
little-cui merged pull request #1175:
URL: https://github.com/apache/servicecomb-service-center/pull/1175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1175: [feat] add eventbase
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1175:
URL: https://github.com/apache/servicecomb-service-center/pull/1175#discussion_r764666568
##########
File path: eventbase/datasource/tombstone.go
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource
+
+import (
+ "context"
+
+ "github.com/go-chassis/cari/sync"
+)
+
+// TombstoneDao provide api of Tombstone entity
+type TombstoneDao interface {
+ Get(ctx context.Context, domain string, project string, resourceType string, taskID string) (*sync.Tombstone, error)
Review comment:
参数太多，需要struct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] tianxiaoliang commented on a change in pull request #1175: [feat] add eventbase
Posted by GitBox <gi...@apache.org>.
tianxiaoliang commented on a change in pull request #1175:
URL: https://github.com/apache/servicecomb-service-center/pull/1175#discussion_r764667832
##########
File path: eventbase/datasource/manager.go
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource
+
+import (
+ "fmt"
+ "time"
+
+ "github.com/go-chassis/openlog"
+)
+
+const DefaultTimeout = 60 * time.Second
+
+var (
+ dataSourceInst DataSource
+ plugins = make(map[string]dataSourceEngine)
+)
+
+type dataSourceEngine func(c *DBConfig) (DataSource, error)
+
+func GetDataSource() DataSource {
+ return dataSourceInst
+}
+
+func RegisterPlugin(name string, engineFunc dataSourceEngine) {
+ plugins[name] = engineFunc
+}
+
+func Init(c DBConfig) error {
+ var err error
+ if c.Kind == "" {
+ c.Kind = "mongo"
+ }
+ f, ok := plugins[c.Kind]
+ if !ok {
+ return fmt.Errorf("do not support %s", c.Kind)
+ }
+ if c.Timeout == 0 {
+ c.Timeout = DefaultTimeout
+ }
+ dbc := &DBConfig{
Review comment:
DBConfig 是否可以放到cari，其实是经常出现的东西
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] robotLJW commented on a change in pull request #1175: [feat] add eventbase
Posted by GitBox <gi...@apache.org>.
robotLJW commented on a change in pull request #1175:
URL: https://github.com/apache/servicecomb-service-center/pull/1175#discussion_r764701224
##########
File path: eventbase/datasource/manager.go
##########
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource
+
+import (
+ "fmt"
+ "time"
+
+ "github.com/go-chassis/openlog"
+)
+
+const DefaultTimeout = 60 * time.Second
+
+var (
+ dataSourceInst DataSource
+ plugins = make(map[string]dataSourceEngine)
+)
+
+type dataSourceEngine func(c *DBConfig) (DataSource, error)
+
+func GetDataSource() DataSource {
+ return dataSourceInst
+}
+
+func RegisterPlugin(name string, engineFunc dataSourceEngine) {
+ plugins[name] = engineFunc
+}
+
+func Init(c DBConfig) error {
+ var err error
+ if c.Kind == "" {
+ c.Kind = "mongo"
+ }
+ f, ok := plugins[c.Kind]
+ if !ok {
+ return fmt.Errorf("do not support %s", c.Kind)
+ }
+ if c.Timeout == 0 {
+ c.Timeout = DefaultTimeout
+ }
+ dbc := &DBConfig{
Review comment:
已经放到cari中
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [servicecomb-service-center] robotLJW commented on a change in pull request #1175: [feat] add eventbase
Posted by GitBox <gi...@apache.org>.
robotLJW commented on a change in pull request #1175:
URL: https://github.com/apache/servicecomb-service-center/pull/1175#discussion_r764701684
##########
File path: eventbase/datasource/tombstone.go
##########
@@ -0,0 +1,33 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package datasource
+
+import (
+ "context"
+
+ "github.com/go-chassis/cari/sync"
+)
+
+// TombstoneDao provide api of Tombstone entity
+type TombstoneDao interface {
+ Get(ctx context.Context, domain string, project string, resourceType string, taskID string) (*sync.Tombstone, error)
Review comment:
已经使用model 中的 GetTombstoneRequest
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org