You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Amogh Shetkar <as...@pivotal.io> on 2015/08/04 10:48:33 UTC
Review Request 37068: GEODE-155:
RegionWithHDFS*BasicDUnitTest.testWOTimeForRollOverParam failed due to
incorrect number of files created.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37068/
-----------------------------------------------------------
Review request for geode, Ashvin A and Darrel Schneider.
Repository: geode
Description
-------
GEODE-155:
- Fixes intermittent failure in RegionWithHDFS*DUnitTest about incorrect number of hoplog files getting created.
- Caused due to an earlier test not cleaning up static variables in ParallelGatewaySenderQueue.
- These are indeed cleaned up during GemFireCacheImpl.close() if there are any GatewaySenders running in the system.
- But if a region with gateway-senders associated with it, is destroyed first before a cache.close(), then the gateway senders are only stopped, and removed from allGatewaySenders list. But the static variables are not cleaned up.
- Later, during GemFireCacheImpl.close(), as the allGatewaySenders list is empty, it skips cleaning the static variables.
- As a fix, invoking a static clean-up method of ParallelGatewaySenderQueue explicitly during cache.close().
- Retained the non-static ParallelGatewaySenderQueue.cleanUp(), if required in future development for performing instance-specific clean-up.
- Minor formatting changes in the unit tests.
Diffs
-----
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 54870002be6d2aadd5232e317661b668fc92be7b
gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java f4f9528b460e019a1c50f9a9f975dfa09cd47110
gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/RegionWithHDFSBasicDUnitTest.java cf10b24b314c2a3f6687ed20283daa11bb9ebdae
gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/RegionWithHDFSOffHeapBasicDUnitTest.java 21e2986532f4f8b843edffe2bb405f76bd260fd8
gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/RegionWithHDFSTestBase.java 8ad57c9daf50db41f6cffa69adaba76fb2bdd5fb
Diff: https://reviews.apache.org/r/37068/diff/
Testing
-------
./gradlew clean build
Thanks,
Amogh Shetkar
Re: Review Request 37068: GEODE-155:
RegionWithHDFS*BasicDUnitTest.testWOTimeForRollOverParam failed due to
incorrect number of files created.
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37068/#review94075
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Aug. 4, 2015, 1:48 a.m., Amogh Shetkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37068/
> -----------------------------------------------------------
>
> (Updated Aug. 4, 2015, 1:48 a.m.)
>
>
> Review request for geode, Ashvin A and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-155:
> - Fixes intermittent failure in RegionWithHDFS*DUnitTest about incorrect number of hoplog files getting created.
> - Caused due to an earlier test not cleaning up static variables in ParallelGatewaySenderQueue.
> - These are indeed cleaned up during GemFireCacheImpl.close() if there are any GatewaySenders running in the system.
> - But if a region with gateway-senders associated with it, is destroyed first before a cache.close(), then the gateway senders are only stopped, and removed from allGatewaySenders list. But the static variables are not cleaned up.
> - Later, during GemFireCacheImpl.close(), as the allGatewaySenders list is empty, it skips cleaning the static variables.
> - As a fix, invoking a static clean-up method of ParallelGatewaySenderQueue explicitly during cache.close().
> - Retained the non-static ParallelGatewaySenderQueue.cleanUp(), if required in future development for performing instance-specific clean-up.
> - Minor formatting changes in the unit tests.
>
>
> Diffs
> -----
>
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/GemFireCacheImpl.java 54870002be6d2aadd5232e317661b668fc92be7b
> gemfire-core/src/main/java/com/gemstone/gemfire/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java f4f9528b460e019a1c50f9a9f975dfa09cd47110
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/RegionWithHDFSBasicDUnitTest.java cf10b24b314c2a3f6687ed20283daa11bb9ebdae
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/RegionWithHDFSOffHeapBasicDUnitTest.java 21e2986532f4f8b843edffe2bb405f76bd260fd8
> gemfire-core/src/test/java/com/gemstone/gemfire/cache/hdfs/internal/RegionWithHDFSTestBase.java 8ad57c9daf50db41f6cffa69adaba76fb2bdd5fb
>
> Diff: https://reviews.apache.org/r/37068/diff/
>
>
> Testing
> -------
>
> ./gradlew clean build
>
>
> Thanks,
>
> Amogh Shetkar
>
>