You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/08 20:58:31 UTC
[GitHub] [nifi] MikeThomsen opened a new pull request, #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…
MikeThomsen opened a new pull request, #6635:
URL: https://github.com/apache/nifi/pull/6635
…ntrollerService.
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 8
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on pull request #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6635:
URL: https://github.com/apache/nifi/pull/6635#issuecomment-1307936037
+1 LGTM, Verified happy-path and non-happy-path behaviors during verification of the controller service. Thanks for the improvement! Merging to main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a diff in pull request #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on code in PR #6635:
URL: https://github.com/apache/nifi/pull/6635#discussion_r1017219798
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-client-service-api/src/main/java/org/apache/nifi/mongodb/MongoDBClientService.java:
##########
@@ -40,33 +41,33 @@ public interface MongoDBClientService extends ControllerService {
String WRITE_CONCERN_W2 = "W2";
String WRITE_CONCERN_W3 = "W3";
- static final AllowableValue WRITE_CONCERN_ACKNOWLEDGED_VALUE = new AllowableValue(
Review Comment:
IntelliJ said that was redundant, so I removed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 closed pull request #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…
Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…
URL: https://github.com/apache/nifi/pull/6635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…
Posted by GitBox <gi...@apache.org>.
exceptionfactory commented on code in PR #6635:
URL: https://github.com/apache/nifi/pull/6635#discussion_r1017169545
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-client-service-api/src/main/java/org/apache/nifi/mongodb/MongoDBClientService.java:
##########
@@ -40,33 +41,33 @@ public interface MongoDBClientService extends ControllerService {
String WRITE_CONCERN_W2 = "W2";
String WRITE_CONCERN_W3 = "W3";
- static final AllowableValue WRITE_CONCERN_ACKNOWLEDGED_VALUE = new AllowableValue(
Review Comment:
This is a helpful improvement, `static final` is implicit on members of an interface definition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a diff in pull request #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…
Posted by GitBox <gi...@apache.org>.
mattyb149 commented on code in PR #6635:
URL: https://github.com/apache/nifi/pull/6635#discussion_r1017158003
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-client-service-api/src/main/java/org/apache/nifi/mongodb/MongoDBClientService.java:
##########
@@ -40,33 +41,33 @@ public interface MongoDBClientService extends ControllerService {
String WRITE_CONCERN_W2 = "W2";
String WRITE_CONCERN_W3 = "W3";
- static final AllowableValue WRITE_CONCERN_ACKNOWLEDGED_VALUE = new AllowableValue(
Review Comment:
Is there a reason that these shouldn't be `static final`? Otherwise this LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #6635: NIFI-10781 Made the MongoDB controller service implement VerifiableCo…
Posted by GitBox <gi...@apache.org>.
MikeThomsen commented on PR #6635:
URL: https://github.com/apache/nifi/pull/6635#issuecomment-1307974388
thanks for the fast review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org