You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@burr.apache.org by "Kamehameya (via GitHub)" <gi...@apache.org> on 2026/04/06 18:15:05 UTC
[PR] Amey/typescript implementation extension [burr]
Kamehameya opened a new pull request, #728:
URL: https://github.com/apache/burr/pull/728
[Short description explaining the high-level reason for the pull request]
## Changes
## How I tested this
## Notes
## Checklist
- [ ] PR has an informative and human-readable title (this will be pulled into the release notes)
- [ ] Changes are limited to a single goal (no scope creep)
- [ ] Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
- [ ] Any _change_ in functionality is tested
- [ ] New functions are documented (with a description, list of inputs, and expected output)
- [ ] Placeholder code is flagged / future TODOs are captured in comments
- [ ] Project documentation has been updated if adding/changing functionality.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amey/typescript implementation extension [burr]
Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz commented on PR #728:
URL: https://github.com/apache/burr/pull/728#issuecomment-5059539851
We need to look over this from an apache angle and build some process around it to be able to release it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amey/typescript implementation extension [burr]
Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz commented on PR #728:
URL: https://github.com/apache/burr/pull/728#issuecomment-4200813514
PR description? How can I run this locally?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amey/typescript implementation extension [burr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #728:
URL: https://github.com/apache/burr/pull/728#issuecomment-4325942252
This PR has been inactive for 19 days after receiving review feedback.
Converting to draft.
Please mark it as ready for review when you have addressed the comments.
If no activity occurs within 90 days, it will be closed automatically.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amey/typescript implementation extension [burr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #728:
URL: https://github.com/apache/burr/pull/728#issuecomment-6412819157
This PR has had no activity for 94 days.
Closing to keep the PR list manageable.
Feel free to reopen when you are ready to continue.
If the branch has conflicts, a fresh PR against `main` might be easier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amey/typescript implementation extension [burr]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #728: Amey/typescript implementation extension
URL: https://github.com/apache/burr/pull/728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amey/typescript implementation extension [burr]
Posted by "Kamehameya (via GitHub)" <gi...@apache.org>.
Kamehameya commented on PR #728:
URL: https://github.com/apache/burr/pull/728#issuecomment-4339211429
> PR description? How can I run this locally?
Added the description
Testing:
```
git checkout amey/typescript-implementation-extension
cd typescript/packages/burr-core
npm install
npx jest --no-coverage
```
Run the integration test specifically (mirrors Python's tests/integration_tests/test_app.py):
```
npx jest src/__tests__/integration.test.ts --no-coverage
```
Run the hello-world counter demo (port of examples/hello-world-counter/application.py):
```
npx ts-node scratch-examples/hello-world-counter.ts
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Amey/typescript implementation extension [burr]
Posted by "skrawcz (via GitHub)" <gi...@apache.org>.
skrawcz commented on code in PR #728:
URL: https://github.com/apache/burr/pull/728#discussion_r3046619872
##########
typescript/packages/burr-core/scratch-examples/counter-hw.ts:
##########
@@ -0,0 +1,102 @@
+import { z } from "zod";
Review Comment:
? otherwise needs apache license.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@burr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org