[GitHub] [spark] zhouyejoe commented on pull request #42136: [SPARK-43100][CORE] Mismatch of field name in log event writer and parser for push shuffle metrics

["zhouyejoe (via GitHub)" <gi...@apache.org>]

zhouyejoe commented on PR #42136:
URL: https://github.com/apache/spark/pull/42136#issuecomment-1662863188

   There are existing tests for querying rest calls and verify the Json response in HistoryServerSuite:
       "stage list with peak metrics" -> "applications/app-20200706201101-0003/stages",
       "stage with peak metrics" -> "applications/app-20200706201101-0003/stages/2/0",
       "stage with summaries" -> "applications/app-20200706201101-0003/stages/2/0?withSummaries=true",
   
   However, a big missing pieces in UT that can reveal to the existing issue is:
   Generating the event with the JsonProtocol toJson methods, and parse it in HistoryServerSuite.
   @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org