[GitHub] [opennlp] jzonthemtn commented on a diff in pull request #516: OPENNLP-1474 Create tokenizer factories for other langs (Spanish, Italian, ...)

["jzonthemtn (via GitHub)" <gi...@apache.org>]

jzonthemtn commented on code in PR #516:
URL: https://github.com/apache/opennlp/pull/516#discussion_r1125507009


##########
opennlp-tools/src/main/java/opennlp/tools/tokenize/lang/Factory.java:
##########
@@ -43,18 +53,25 @@ public class Factory {
    */
   public Pattern getAlphanumeric(String languageCode) {

Review Comment:
   At some point would it make sense to have `languageCode` be an enum instead of a string?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org