You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/06 00:22:56 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request #27470:
[MINOR][BUILD] Factor Python executable out as a variable in 'lint-python'
script
HyukjinKwon opened a new pull request #27470: [MINOR][BUILD] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470
### What changes were proposed in this pull request?
This PR proposes to make hardcoded `python3` to a variable `PYTHON_EXECUTABLE` in ' lint-python' script.
### Why are the changes needed?
To make changes easier. See https://github.com/apache/spark/commit/561e9b968821ca3e501aa5cba7ba5ceaa45796ea as an example.
### Does this PR introduce any user-facing change?
No
### How was this patch tested?
Manually by running `dev/lint-python`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27470:
[MINOR][INFRA] Factor Python executable out as a variable in 'lint-python'
script
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582712856
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #27470: [MINOR][INFRA]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #27470:
[MINOR][INFRA] Factor Python executable out as a variable in 'lint-python'
script
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582685910
1. GitHub Action `linter-python` passed.
2. Jenkins `linter-python` passed.
```
========================================================================
Running Python style checks
========================================================================
starting python compilation test...
python compilation succeeded.
downloading pycodestyle from https://raw.githubusercontent.com/PyCQA/pycodestyle/2.4.0/pycodestyle.py...
starting pycodestyle test...
pycodestyle checks passed.
starting flake8 test...
flake8 checks passed.
The pydocstyle command was not found. Skipping pydocstyle checks for now.
starting sphinx-build tests...
sphinx-build checks passed.
all lint-python tests passed!
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27470: [MINOR][INFRA]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582678988
**[Test build #117957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117957/testReport)** for PR 27470 at commit [`a620ae2`](https://github.com/apache/spark/commit/a620ae2d3bae89f6a1484165db8c65e1a70e860b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun edited a comment on issue #27470:
[MINOR][INFRA] Factor Python executable out as a variable in 'lint-python'
script
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582685910
1. GitHub Action `lint-python` passed.
2. Jenkins `lint-python` passed.
```
========================================================================
Running Python style checks
========================================================================
starting python compilation test...
python compilation succeeded.
downloading pycodestyle from https://raw.githubusercontent.com/PyCQA/pycodestyle/2.4.0/pycodestyle.py...
starting pycodestyle test...
pycodestyle checks passed.
starting flake8 test...
flake8 checks passed.
The pydocstyle command was not found. Skipping pydocstyle checks for now.
starting sphinx-build tests...
sphinx-build checks passed.
all lint-python tests passed!
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on issue #27470: [MINOR][INFRA]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582686296
Thanks @shaneknapp and @dongjoon-hyun!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27470:
[MINOR][BUILD] Factor Python executable out as a variable in 'lint-python'
script
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27470: [MINOR][BUILD] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582679325
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27470: [MINOR][INFRA] Factor
Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582712426
**[Test build #117957 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117957/testReport)** for PR 27470 at commit [`a620ae2`](https://github.com/apache/spark/commit/a620ae2d3bae89f6a1484165db8c65e1a70e860b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27470: [MINOR][BUILD]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27470: [MINOR][BUILD] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582679325
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27470:
[MINOR][INFRA] Factor Python executable out as a variable in 'lint-python'
script
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582712861
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117957/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27470: [MINOR][BUILD]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27470: [MINOR][BUILD] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582679332
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22721/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27470: [MINOR][INFRA]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582686206
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] shaneknapp commented on issue #27470: [MINOR][BUILD] Factor
Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
shaneknapp commented on issue #27470: [MINOR][BUILD] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582682890
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on issue #27470: [MINOR][INFRA]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582685910
GitHub Action `linter-python` passed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27470:
[MINOR][BUILD] Factor Python executable out as a variable in 'lint-python'
script
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27470: [MINOR][BUILD] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582679332
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/22721/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27470: [MINOR][INFRA]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582712856
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27470: [MINOR][BUILD] Factor
Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27470: [MINOR][BUILD] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582678988
**[Test build #117957 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/117957/testReport)** for PR 27470 at commit [`a620ae2`](https://github.com/apache/spark/commit/a620ae2d3bae89f6a1484165db8c65e1a70e860b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27470: [MINOR][INFRA]
Factor Python executable out as a variable in 'lint-python' script
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27470: [MINOR][INFRA] Factor Python executable out as a variable in 'lint-python' script
URL: https://github.com/apache/spark/pull/27470#issuecomment-582712861
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/117957/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org