You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by Se...@t-systems.com on 2014/04/03 09:16:48 UTC

'title' attribut not being rendered using 

Hello everyone,

I have just run into a problem where the 'title' attribut is not being rendered using the <h:selectOneMenu> tag.
Used version is MyFaces Core 2.2.2

I had a look into the source code and the following changes seem to fix the problem:


Class: org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils

Method: renderSelectOptions (Line 521)
Code changes listed on pastebin: http://pastebin.com/SHLKxi5H

Can someone confirm this, because I wanted to ask the ML first before opening an issue via Apache JIRA for MyFaces?!


Thanks and regards,
Sebastian

Re: 'title' attribut not being rendered using

Posted by Leonardo Uribe <lu...@gmail.com>.
Hi

Issue created:

https://issues.apache.org/jira/browse/MYFACES-3879

MYFACES-3879 - Passthrough attributes for f:selectItem and
f:selectItems should be rendered by associated components

regards,

Leonardo


2014-04-04 17:34 GMT+02:00 Leonardo Uribe <lu...@gmail.com>:
> Hi
>
> I have checked the code and this is something that should be
> specified. But it seems to be a but because in the renderkit javadoc
> of javax.faces.SelectMany/javax.faces.Listbox it says this:
>
> "... In both the case of the "option" element or the "optgroup"
> element, the implementation must pass the UISelectItem or
> UISelectItems corresponding to the SelectItem bean to the call to
> ResponseWriter.startElement(). ..."
>
> That has the effect of render passthrough attributes from f:selectItem
> and f:selectItems. It should be valid to use something like this:
>
>     <h:selectManyMenu id="menu">
>         <f:selectItem itemValue="One"/>
>         <f:selectItem itemValue="Two" pt:title="Title Two"/>
>     </h:selectManyMenu>
>
> I'll fix that.
>
> regards,
>
> Leonardo Uribe
>
>
> 2014-04-03 9:16 GMT+02:00  <Se...@t-systems.com>:
>> Hello everyone,
>>
>>
>>
>> I have just run into a problem where the 'title' attribut is not being
>> rendered using the <h:selectOneMenu> tag.
>>
>> Used version is MyFaces Core 2.2.2
>>
>>
>>
>> I had a look into the source code and the following changes seem to fix the
>> problem:
>>
>>
>>
>> Class: org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils
>>
>> Method: renderSelectOptions (Line 521)
>>
>> Code changes listed on pastebin: http://pastebin.com/SHLKxi5H
>>
>>
>>
>> Can someone confirm this, because I wanted to ask the ML first before
>> opening an issue via Apache JIRA for MyFaces?!
>>
>>
>>
>>
>> Thanks and regards,
>>
>> Sebastian

Re: 'title' attribut not being rendered using

Posted by Leonardo Uribe <lu...@gmail.com>.
Hi

I have checked the code and this is something that should be
specified. But it seems to be a but because in the renderkit javadoc
of javax.faces.SelectMany/javax.faces.Listbox it says this:

"... In both the case of the "option" element or the "optgroup"
element, the implementation must pass the UISelectItem or
UISelectItems corresponding to the SelectItem bean to the call to
ResponseWriter.startElement(). ..."

That has the effect of render passthrough attributes from f:selectItem
and f:selectItems. It should be valid to use something like this:

    <h:selectManyMenu id="menu">
        <f:selectItem itemValue="One"/>
        <f:selectItem itemValue="Two" pt:title="Title Two"/>
    </h:selectManyMenu>

I'll fix that.

regards,

Leonardo Uribe


2014-04-03 9:16 GMT+02:00  <Se...@t-systems.com>:
> Hello everyone,
>
>
>
> I have just run into a problem where the 'title' attribut is not being
> rendered using the <h:selectOneMenu> tag.
>
> Used version is MyFaces Core 2.2.2
>
>
>
> I had a look into the source code and the following changes seem to fix the
> problem:
>
>
>
> Class: org.apache.myfaces.shared.renderkit.html.HtmlRendererUtils
>
> Method: renderSelectOptions (Line 521)
>
> Code changes listed on pastebin: http://pastebin.com/SHLKxi5H
>
>
>
> Can someone confirm this, because I wanted to ask the ML first before
> opening an issue via Apache JIRA for MyFaces?!
>
>
>
>
> Thanks and regards,
>
> Sebastian