You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "hyongtao-code (via GitHub)" <gi...@apache.org> on 2026/05/25 13:42:06 UTC
[PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
hyongtao-code opened a new pull request, #63630:
URL: https://github.com/apache/doris/pull/63630
Long log:
The null check was mistakenly performed on the `id` parameter instead of the `dict` returned from `idToDictionary.remove(id)`.
Signed-off-by: Yongtao Huang <yo...@gmail.com>
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [X] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [X] No.
- [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4536146676
# FE Regression Coverage Report
Increment line coverage ` 0.00% (0/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63630_0e1d2a642a6675468c94debe5b539864a9e04cb4_merge_fe/increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63630_0e1d2a642a6675468c94debe5b539864a9e04cb4_merge_fe/report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #63630:
URL: https://github.com/apache/doris/pull/63630
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4591215873
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4591216310
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4534723625
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
Please clearly describe your PR:
1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4535522721
<details>
<summary>TPC-H: <b>Total hot run time: 32440 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0e1d2a642a6675468c94debe5b539864a9e04cb4, data reload: false
------ Round 1 ----------------------------------
orders Doris NULL NULL 0 0 0 NULL 0 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 17629 4121 4105 4105
q2 q3 10819 1405 843 843
q4 4690 486 352 352
q5 7628 2310 2175 2175
q6 249 184 141 141
q7 955 798 670 670
q8 9385 1673 1671 1671
q9 5164 5030 4984 4984
q10 6419 2262 1890 1890
q11 440 287 261 261
q12 639 437 315 315
q13 18086 3334 2815 2815
q14 280 272 244 244
q15 q16 838 776 716 716
q17 1005 985 992 985
q18 6893 5867 5679 5679
q19 1303 1268 1212 1212
q20 570 490 298 298
q21 6341 2909 2766 2766
q22 460 376 318 318
Total cold run time: 99793 ms
Total hot run time: 32440 ms
----- Round 2, with runtime_filter_mode=off -----
orders Doris NULL NULL 150000000 42 6422171781 NULL 22778155 NULL NULL 2023-12-26 18:27:23 2023-12-26 18:42:55 NULL utf-8 NULL NULL
============================================
q1 4957 4788 4957 4788
q2 q3 4981 5480 4596 4596
q4 2166 2263 1459 1459
q5 5086 4731 4640 4640
q6 251 189 138 138
q7 1908 1780 1589 1589
q8 2469 2179 2171 2171
q9 7949 7455 7433 7433
q10 4784 4696 4258 4258
q11 551 417 383 383
q12 747 745 545 545
q13 3025 3403 2835 2835
q14 289 279 255 255
q15 q16 683 716 630 630
q17 1322 1289 1277 1277
q18 7173 6720 6842 6720
q19 1153 1061 1101 1061
q20 2225 2248 1978 1978
q21 5358 4738 4565 4565
q22 542 465 430 430
Total cold run time: 57619 ms
Total hot run time: 51751 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4535580045
<details>
<summary>TPC-DS: <b>Total hot run time: 172975 ms</b></summary>
```
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0e1d2a642a6675468c94debe5b539864a9e04cb4, data reload: false
query5 4316 655 517 517
query6 339 219 213 213
query7 4217 559 296 296
query8 325 232 228 228
query9 8833 4093 4115 4093
query10 448 372 299 299
query11 5798 2558 2307 2307
query12 187 128 124 124
query13 1348 607 452 452
query14 6159 5550 5239 5239
query14_1 4546 4547 4529 4529
query15 216 211 186 186
query16 1032 481 434 434
query17 1162 792 626 626
query18 2731 495 354 354
query19 220 207 161 161
query20 137 131 129 129
query21 222 138 117 117
query22 13665 13563 13375 13375
query23 17382 16679 16258 16258
query23_1 16412 16481 16501 16481
query24 7374 1763 1317 1317
query24_1 1304 1312 1293 1293
query25 540 492 419 419
query26 1299 305 170 170
query27 2704 567 337 337
query28 4384 2020 1983 1983
query29 991 632 494 494
query30 299 246 200 200
query31 1130 1082 972 972
query32 93 75 71 71
query33 530 349 299 299
query34 1189 1169 662 662
query35 773 792 724 724
query36 1437 1413 1256 1256
query37 152 100 91 91
query38 3238 3171 3067 3067
query39 933 942 915 915
query39_1 878 902 877 877
query40 225 146 127 127
query41 66 68 65 65
query42 112 110 140 110
query43 327 344 299 299
query44
query45 217 205 200 200
query46 1073 1227 726 726
query47 2368 2345 2286 2286
query48 403 419 302 302
query49 641 499 396 396
query50 949 354 257 257
query51 4341 4318 4274 4274
query52 102 107 94 94
query53 241 286 212 212
query54 321 272 247 247
query55 93 90 86 86
query56 308 305 306 305
query57 1424 1413 1334 1334
query58 302 270 270 270
query59 1581 1689 1434 1434
query60 321 320 295 295
query61 159 160 158 158
query62 730 656 587 587
query63 240 199 208 199
query64 2407 823 650 650
query65
query66 1660 512 360 360
query67 29832 29791 29662 29662
query68
query69 463 348 307 307
query70 1040 1001 1000 1000
query71 313 273 271 271
query72 3055 2777 2384 2384
query73 854 774 432 432
query74 5164 4930 4818 4818
query75 2694 2615 2274 2274
query76 2289 1152 785 785
query77 407 422 341 341
query78 12620 12414 11957 11957
query79 1227 1063 715 715
query80 573 557 455 455
query81 450 284 248 248
query82 243 160 125 125
query83 281 285 259 259
query84 274 145 116 116
query85 925 621 536 536
query86 360 349 328 328
query87 3416 3381 3239 3239
query88 3629 2740 2749 2740
query89 446 389 349 349
query90 2194 187 182 182
query91 199 180 157 157
query92 86 77 79 77
query93 1394 1412 882 882
query94 538 395 319 319
query95 673 383 378 378
query96 1044 742 342 342
query97 2717 2754 2650 2650
query98 236 228 228 228
query99 1204 1156 1033 1033
Total cold run time: 253262 ms
Total hot run time: 172975 ms
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4591206027
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "hyongtao-code (via GitHub)" <gi...@apache.org>.
hyongtao-code commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4535319435
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4535784975
# FE UT Coverage Report
Increment line coverage ` 0.00% (0/1)` :tada:
[Increment coverage report](http://coverage.selectdb-in.cc/coverage/63630_0e1d2a642a6675468c94debe5b539864a9e04cb4/fe_increment_report/index.html)
[Complete coverage report](http://coverage.selectdb-in.cc/coverage/63630_0e1d2a642a6675468c94debe5b539864a9e04cb4/fe_report/index.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [Chore] correct null check in `DictionaryManager.dropTableDictionaries()` [doris]
Posted by "hyongtao-code (via GitHub)" <gi...@apache.org>.
hyongtao-code commented on PR #63630:
URL: https://github.com/apache/doris/pull/63630#issuecomment-4553626039
/review
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org