You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/17 15:04:17 UTC

[GitHub] [flink] zentol commented on a diff in pull request #19968: [FLINK-27972][coordination] Wait until savepoint operation is complete

zentol commented on code in PR #19968:
URL: https://github.com/apache/flink/pull/19968#discussion_r900209065


##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/StopWithSavepoint.java:
##########
@@ -132,6 +146,7 @@ public void onLeave(Class<? extends State> newState) {
 
     @Override
     public void cancel() {
+        operationFailureCause = new FlinkException("The job was cancelled.");

Review Comment:
   document why we dont wait for the future here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org