[jira] [Commented] (FLINK-28575) support hbase connector 2.2 to write to hbase 2.4.9

["Martijn Visser (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-28575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17567824#comment-17567824 ] 

Martijn Visser commented on FLINK-28575:
----------------------------------------

While it might not be necessary to have such restrictions, I am in favour of them (as I've included in the PR). There are no tests for these type of version supports, they are not or incorrectly documented and can cause unexpected CI results. If we want to have support for a specific version, we should add it. Same as we do with the Hive connector. 

> support hbase connector 2.2 to write to hbase 2.4.9
> ---------------------------------------------------
>
>                 Key: FLINK-28575
>                 URL: https://issues.apache.org/jira/browse/FLINK-28575
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / HBase
>            Reporter: Zhen Wang
>            Priority: Major
>              Labels: pull-request-available
>
> hbase does version checks when creating configurations by default
> ```
>   private static void checkDefaultsVersion(Configuration conf) {
>     if (conf.getBoolean("hbase.defaults.for.version.skip", Boolean.FALSE)) return;
>     String defaultsVersion = conf.get("hbase.defaults.for.version");
>     String thisVersion = VersionInfo.getVersion();
>     if (!thisVersion.equals(defaultsVersion)) {
>       throw new RuntimeException(
>         "hbase-default.xml file seems to be for an older version of HBase (" +
>         defaultsVersion + "), this version is " + thisVersion);
>     }
>   }
> ```
> so this prevents using connector2.2 to write to like hbase 2.4.9. however this restriction is not necessary. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)