You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by li...@apache.org on 2016/12/09 04:13:39 UTC
kylin git commit: bug fix in FunctionDesc.hashCode()
Repository: kylin
Updated Branches:
refs/heads/master 7ae06634e -> 01060b574
bug fix in FunctionDesc.hashCode()
Project: http://git-wip-us.apache.org/repos/asf/kylin/repo
Commit: http://git-wip-us.apache.org/repos/asf/kylin/commit/01060b57
Tree: http://git-wip-us.apache.org/repos/asf/kylin/tree/01060b57
Diff: http://git-wip-us.apache.org/repos/asf/kylin/diff/01060b57
Branch: refs/heads/master
Commit: 01060b574cb6186f040dac398e2eb2a90b052d42
Parents: 7ae0663
Author: Yang Li <li...@apache.org>
Authored: Fri Dec 9 12:11:08 2016 +0800
Committer: Yang Li <li...@apache.org>
Committed: Fri Dec 9 12:11:08 2016 +0800
----------------------------------------------------------------------
.../main/java/org/apache/kylin/metadata/model/FunctionDesc.java | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kylin/blob/01060b57/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
----------------------------------------------------------------------
diff --git a/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java b/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
index 9252c42..ac13f40 100644
--- a/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
+++ b/core-metadata/src/main/java/org/apache/kylin/metadata/model/FunctionDesc.java
@@ -240,8 +240,8 @@ public class FunctionDesc {
final int prime = 31;
int result = 1;
result = prime * result + ((expression == null) ? 0 : expression.hashCode());
- result = prime * result + ((returnType == null) ? 0 : returnType.hashCode());
result = prime * result + ((isCount() || parameter == null) ? 0 : parameter.hashCode());
+ // NOTE: don't compare returnType, FunctionDesc created at query engine does not have a returnType
return result;
}
@@ -272,6 +272,7 @@ public class FunctionDesc {
return false;
}
}
+ // NOTE: don't compare returnType, FunctionDesc created at query engine does not have a returnType
return true;
}