[GitHub] [incubator-iceberg] ashleycoxley commented on a change in pull request #487: Add TIME_MICROS support to GenericParquetReaders

[GitBox <gi...@apache.org>]

ashleycoxley commented on a change in pull request #487: Add TIME_MICROS support to GenericParquetReaders
URL: https://github.com/apache/incubator-iceberg/pull/487#discussion_r326828391
 
 

 ##########
 File path: data/src/main/java/org/apache/iceberg/data/parquet/GenericParquetReaders.java
 ##########
 @@ -366,6 +365,15 @@ public OffsetDateTime read(OffsetDateTime reuse) {
     }
   }
 
+  private static class TimeReader extends PrimitiveReader<LocalTime> {
+    private TimeReader(ColumnDescriptor desc) {
+      super(desc);
+    }
+
+    @Override
+    public LocalTime read(LocalTime reuse) { return LocalTime.MIN.plus(column.nextLong(), ChronoUnit.MICROS); }
 
 Review comment:
   Sure thing - will change this and write that test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org