Re: [PR] [SPARK-40295][SQL] Allow v2 functions with literal args in write distribution/ordering [spark]

["faucct (via GitHub)" <gi...@apache.org>]

faucct commented on code in PR #37749:
URL: https://github.com/apache/spark/pull/37749#discussion_r1430050128


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala:
##########
@@ -361,6 +361,18 @@ object KeyGroupedPartitioning {
       partitionValues: Seq[InternalRow]): KeyGroupedPartitioning = {
     KeyGroupedPartitioning(expressions, partitionValues.size, Some(partitionValues))
   }
+
+  def supportsExpressions(expressions: Seq[Expression]): Boolean = {

Review Comment:
   Is this expected to fail for both `BucketTransform` and `SortedBucketTransform`, which always have more than 1 child expression?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org