You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/27 01:15:04 UTC
[GitHub] [arrow] arw2019 opened a new pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
arw2019 opened a new pull request #8782:
URL: https://github.com/apache/arrow/pull/8782
As per a TODO left in ARROW-3769 / #3721 we can now use the `GTEST_SKIP` macro in `parquet/encoding-test.cpp`. `GTEST_SKIP` was added in gtest 1.10.0 so this involves bumping our minimal gtest version from 1.8.1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in parquet encoding tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-734472714
https://issues.apache.org/jira/browse/ARROW-10746
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-739625768
Revision: f3f04e865633d2ceb5ad805e49b311fcbea08084
Submitted crossbow builds: [ursa-labs/crossbow @ actions-743](https://github.com/ursa-labs/crossbow/branches/all?query=actions-743)
|Task|Status|
|----|------|
|centos-7-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-7-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-centos-7-amd64)|
|centos-8-aarch64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|centos-8-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-centos-8-amd64)|
|conda-clean|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-clean)|
|conda-linux-gcc-py36-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py36-cpu-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-linux-gcc-py36-cpu-r36)|
|conda-linux-gcc-py36-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-linux-gcc-py36-cuda)|
|conda-linux-gcc-py37-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py37-cpu-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-linux-gcc-py37-cpu-r40)|
|conda-linux-gcc-py37-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-linux-gcc-py37-cuda)|
|conda-linux-gcc-py38-aarch64|[](https://cloud.drone.io/ursa-labs/crossbow)|
|conda-linux-gcc-py38-cpu|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-linux-gcc-py38-cpu)|
|conda-linux-gcc-py38-cuda|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-linux-gcc-py38-cuda)|
|conda-osx-clang-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-osx-clang-py36-r36)|
|conda-osx-clang-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-osx-clang-py37-r40)|
|conda-osx-clang-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-osx-clang-py38)|
|conda-win-vs2017-py36-r36|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-win-vs2017-py36-r36)|
|conda-win-vs2017-py37-r40|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-win-vs2017-py37-r40)|
|conda-win-vs2017-py38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-conda-win-vs2017-py38)|
|debian-buster-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-debian-buster-amd64)|
|debian-buster-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|debian-stretch-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-debian-stretch-amd64)|
|debian-stretch-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|example-cpp-minimal-build-static|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-example-cpp-minimal-build-static)|
|example-cpp-minimal-build-static-system-dependency|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-example-cpp-minimal-build-static-system-dependency)|
|gandiva-jar-osx|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|gandiva-jar-xenial|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|homebrew-cpp|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|homebrew-r-autobrew|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|nuget|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-nuget)|
|test-conda-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-cpp)|
|test-conda-cpp-valgrind|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-cpp-valgrind)|
|test-conda-python-3.6|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.6)|
|test-conda-python-3.6-pandas-0.23|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.6-pandas-0.23)|
|test-conda-python-3.7|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7)|
|test-conda-python-3.7-dask-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-dask-latest)|
|test-conda-python-3.7-hdfs-2.9.2|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-hdfs-2.9.2)|
|test-conda-python-3.7-kartothek-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-kartothek-latest)|
|test-conda-python-3.7-kartothek-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-kartothek-master)|
|test-conda-python-3.7-pandas-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-pandas-latest)|
|test-conda-python-3.7-pandas-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-pandas-master)|
|test-conda-python-3.7-spark-branch-3.0|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-spark-branch-3.0)|
|test-conda-python-3.7-turbodbc-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-turbodbc-latest)|
|test-conda-python-3.7-turbodbc-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.7-turbodbc-master)|
|test-conda-python-3.8|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.8)|
|test-conda-python-3.8-dask-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.8-dask-master)|
|test-conda-python-3.8-hypothesis|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.8-hypothesis)|
|test-conda-python-3.8-jpype|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.8-jpype)|
|test-conda-python-3.8-pandas-latest|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.8-pandas-latest)|
|test-conda-python-3.8-spark-master|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-conda-python-3.8-spark-master)|
|test-debian-10-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-debian-10-cpp)|
|test-debian-10-go-1.12|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-debian-10-go-1.12)|
|test-debian-10-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-debian-10-python-3)|
|test-debian-c-glib|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-debian-c-glib)|
|test-debian-ruby|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-debian-ruby)|
|test-fedora-33-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-fedora-33-cpp)|
|test-fedora-33-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-fedora-33-python-3)|
|test-r-linux-as-cran|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-r-linux-as-cran)|
|test-r-rhub-ubuntu-gcc-release|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-r-rhub-ubuntu-gcc-release)|
|test-r-rocker-r-base-latest|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-r-rocker-r-base-latest)|
|test-r-rstudio-r-base-3.6-bionic|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-r-rstudio-r-base-3.6-bionic)|
|test-r-rstudio-r-base-3.6-centos6|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-r-rstudio-r-base-3.6-centos6)|
|test-r-rstudio-r-base-3.6-centos8|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-r-rstudio-r-base-3.6-centos8)|
|test-r-rstudio-r-base-3.6-opensuse15|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-r-rstudio-r-base-3.6-opensuse15)|
|test-r-rstudio-r-base-3.6-opensuse42|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-r-rstudio-r-base-3.6-opensuse42)|
|test-ubuntu-16.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-ubuntu-16.04-cpp)|
|test-ubuntu-18.04-cpp|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-ubuntu-18.04-cpp)|
|test-ubuntu-18.04-cpp-cmake32|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-ubuntu-18.04-cpp-cmake32)|
|test-ubuntu-18.04-cpp-release|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-ubuntu-18.04-cpp-release)|
|test-ubuntu-18.04-cpp-static|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-ubuntu-18.04-cpp-static)|
|test-ubuntu-18.04-docs|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-ubuntu-18.04-docs)|
|test-ubuntu-18.04-python-3|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-ubuntu-18.04-python-3)|
|test-ubuntu-18.04-r-sanitizer|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-ubuntu-18.04-r-sanitizer)|
|test-ubuntu-20.04-cpp|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-ubuntu-20.04-cpp)|
|test-ubuntu-20.04-cpp-14|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-ubuntu-20.04-cpp-14)|
|test-ubuntu-20.04-cpp-17|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-test-ubuntu-20.04-cpp-17)|
|test-ubuntu-c-glib|[](https://circleci.com/gh/ursa-labs/crossbow/tree/actions-743-circle-test-ubuntu-c-glib)|
|test-ubuntu-ruby|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-test-ubuntu-ruby)|
|ubuntu-bionic-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-ubuntu-bionic-amd64)|
|ubuntu-bionic-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-focal-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-ubuntu-focal-amd64)|
|ubuntu-focal-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-groovy-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-ubuntu-groovy-amd64)|
|ubuntu-groovy-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|ubuntu-xenial-amd64|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-ubuntu-xenial-amd64)|
|ubuntu-xenial-arm64|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-manylinux1-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux1-cp36m)|
|wheel-manylinux1-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux1-cp37m)|
|wheel-manylinux1-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux1-cp38)|
|wheel-manylinux2010-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux2010-cp36m)|
|wheel-manylinux2010-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux2010-cp37m)|
|wheel-manylinux2010-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux2010-cp38)|
|wheel-manylinux2014-cp36m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux2014-cp36m)|
|wheel-manylinux2014-cp37m|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux2014-cp37m)|
|wheel-manylinux2014-cp38|[](https://dev.azure.com/ursa-labs/crossbow/_build/latest?definitionId=1&branchName=actions-743-azure-wheel-manylinux2014-cp38)|
|wheel-osx-high-sierra-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-high-sierra-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-high-sierra-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-mavericks-cp36m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-mavericks-cp37m|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-osx-mavericks-cp38|[](https://travis-ci.org/ursa-labs/crossbow/branches)|
|wheel-win-cp36m|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-wheel-win-cp36m)|
|wheel-win-cp37m|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-wheel-win-cp37m)|
|wheel-win-cp38|[](https://github.com/ursa-labs/crossbow/actions?query=branch:actions-743-github-wheel-win-cp38)|
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-738626985
Both the Appveyor case and the macOS case are caused by same reason. They can't find GoogleTest's library.
I'll take a look them.
`cpp/src/parquet/statistics_test.cc`: It seems that naming conflict like other build failures but I'm not sure. I'll also take a look it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
arw2019 commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736255535
Is this related in C++ / AMD64 Windows 2019?
```
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(527,33): error C2039: 'TearDownTestCase': is not a member of 'parquet::ByteArray' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-writer-test.vcxproj]
D:\a\arrow\arrow\cpp\src\parquet/types.h(518): message : see declaration of 'parquet::ByteArray' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-writer-test.vcxproj]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(525): message : while compiling class template member function 'testing::internal::SetUpTearDownSuiteFuncType testing::internal::SuiteApiResolver<parquet::test::TestByteArrayValuesWriter>::GetTearDownCaseOrSuite(const char *,int)' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-writer-test.vcxproj]
D:/a/arrow/arrow/cpp/src/parquet/column_writer_test.cc(688): message : see reference to function template instantiation 'testing::internal::SetUpTearDownSuiteFuncType testing::internal::SuiteApiResolver<parquet::test::TestByteArrayValuesWriter>::GetTearDownCaseOrSuite(const char *,int)' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-writer-test.vcxproj]
D:/a/arrow/arrow/cpp/src/parquet/column_writer_test.cc(688): message : see reference to class template instantiation 'testing::internal::SuiteApiResolver<parquet::test::TestByteArrayValuesWriter>' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-writer-test.vcxproj]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(529,33): error C2039: 'TearDownTestSuite': is not a member of 'parquet::ByteArray' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-writer-test.vcxproj]
D:\a\arrow\arrow\cpp\src\parquet/types.h(518): message : see declaration of 'parquet::ByteArray' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-writer-test.vcxproj]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 closed pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
arw2019 closed pull request #8782:
URL: https://github.com/apache/arrow/pull/8782
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736219706
Could you add required GoogleTest version check?
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index bdf15e4bc..60bdf13ad 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1682,7 +1682,7 @@ set(_GTEST_LIBRARY_DIR "${GTEST_PREFIX}/lib")
endmacro()
if(ARROW_TESTING)
- resolve_dependency(GTest)
+ resolve_dependency(GTest REQUIRED_VERSION 1.10.0)
if(NOT GTEST_VENDORED)
# TODO(wesm): This logic does not work correctly with the MSVC static libraries
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on a change in pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
arw2019 commented on a change in pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#discussion_r534540130
##########
File path: cpp/src/parquet/encoding_test.cc
##########
@@ -495,7 +488,9 @@ class TestArrowBuilderDecoding : public ::testing::Test {
void CheckDecodeArrowNonNullUsingDenseBuilder() {
for (auto np : null_probabilities_) {
InitTestCase(np);
- SKIP_TEST_IF(null_count_ > 0)
+ if (null_count_ > 0) {
+ GTEST_SKIP();
Review comment:
Right, done
##########
File path: cpp/src/parquet/encoding_test.cc
##########
@@ -508,7 +503,9 @@ class TestArrowBuilderDecoding : public ::testing::Test {
void CheckDecodeArrowNonNullUsingDictBuilder() {
for (auto np : null_probabilities_) {
InitTestCase(np);
- SKIP_TEST_IF(null_count_ > 0)
+ if (null_count_ > 0) {
+ GTEST_SKIP();
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-739623781
@github-actions crossbow submit -g nightly
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
arw2019 commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-737678759
It's down to three failing checks:
- Appveyor - not sure what the problem is
- C++ / AMD64 MacOS 10.15 - looks like a `gtest` location problem
```
dyld: Library not loaded: @rpath/libgtest_maind.dylib
```
- C++/ AMD64 Windows 2019 - a template instantiation problem in `cpp/src/parquet/statistics_test.cc`
```
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(527,33): error C2039: 'TearDownTestCase': is not a member of 'parquet::ByteArray' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:\a\arrow\arrow\cpp\src\parquet/types.h(518): message : see declaration of 'parquet::ByteArray' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(525): message : while compiling class template member function 'testing::internal::SetUpTearDownSuiteFuncType testing::internal::SuiteApiResolver<TestClass>::GetTearDownCaseOrSuite(const char *,int)' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(705): message : see reference to function template instantiation 'testing::internal::SetUpTearDownSuiteFuncType testing::internal::SuiteApiResolver<TestClass>::GetTearDownCaseOrSuite(const char *,int)' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(706): message : see reference to class template instantiation 'testing::internal::SuiteApiResolver<TestClass>' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(698): message : while compiling class template member function 'bool testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types3<T2,T3,T4>>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::ByteArrayType,
T3=parquet::FLBAType,
T4=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(720): message : see reference to function template instantiation 'bool testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types3<T2,T3,T4>>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::ByteArrayType,
T3=parquet::FLBAType,
T4=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(721): message : see reference to class template instantiation 'testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types3<T2,T3,T4>>' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::ByteArrayType,
T3=parquet::FLBAType,
T4=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(698): message : while compiling class template member function 'bool testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types4<T2,T3,T4,T5>>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::DoubleType,
T3=parquet::ByteArrayType,
T4=parquet::FLBAType,
T5=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(720): message : see reference to function template instantiation 'bool testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types4<T2,T3,T4,T5>>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::DoubleType,
T3=parquet::ByteArrayType,
T4=parquet::FLBAType,
T5=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(721): message : see reference to class template instantiation 'testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types4<T2,T3,T4,T5>>' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::DoubleType,
T3=parquet::ByteArrayType,
T4=parquet::FLBAType,
T5=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(698): message : while compiling class template member function 'bool testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types5<T2,T3,T4,T5,T6>>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::FloatType,
T3=parquet::DoubleType,
T4=parquet::ByteArrayType,
T5=parquet::FLBAType,
T6=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(720): message : see reference to function template instantiation 'bool testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types5<T2,T3,T4,T5,T6>>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::FloatType,
T3=parquet::DoubleType,
T4=parquet::ByteArrayType,
T5=parquet::FLBAType,
T6=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(721): message : see reference to class template instantiation 'testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types5<T2,T3,T4,T5,T6>>' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::FloatType,
T3=parquet::DoubleType,
T4=parquet::ByteArrayType,
T5=parquet::FLBAType,
T6=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(698): message : while compiling class template member function 'bool testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types6<T2,T3,T4,T5,T6,T7>>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::Int64Type,
T3=parquet::FloatType,
T4=parquet::DoubleType,
T5=parquet::ByteArrayType,
T6=parquet::FLBAType,
T7=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(720): message : see reference to function template instantiation 'bool testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types6<T2,T3,T4,T5,T6,T7>>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::Int64Type,
T3=parquet::FloatType,
T4=parquet::DoubleType,
T5=parquet::ByteArrayType,
T6=parquet::FLBAType,
T7=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(721): message : see reference to class template instantiation 'testing::internal::TypeParameterizedTest<Fixture,TestSel,testing::internal::Types6<T2,T3,T4,T5,T6,T7>>' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
with
[
Fixture=parquet::test::TestStatistics,
TestSel=testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,
T2=parquet::Int64Type,
T3=parquet::FloatType,
T4=parquet::DoubleType,
T5=parquet::ByteArrayType,
T6=parquet::FLBAType,
T7=parquet::BooleanType
]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(698): message : while compiling class template member function 'bool testing::internal::TypeParameterizedTest<parquet::test::TestStatistics,testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,parquet::test::gtest_type_params_TestStatistics_>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:/a/arrow/arrow/cpp/src/parquet/statistics_test.cc(490): message : see reference to function template instantiation 'bool testing::internal::TypeParameterizedTest<parquet::test::TestStatistics,testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,parquet::test::gtest_type_params_TestStatistics_>::Register(const char *,const testing::internal::CodeLocation &,const char *,const char *,int,const std::vector<std::string,std::allocator<std::string>> &)' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:/a/arrow/arrow/cpp/src/parquet/statistics_test.cc(490): message : see reference to class template instantiation 'testing::internal::TypeParameterizedTest<parquet::test::TestStatistics,testing::internal::TemplateSel<parquet::test::TestStatistics_MinMaxEncode_Test>,parquet::test::gtest_type_params_TestStatistics_>' being compiled [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:\a\arrow\arrow\build\cpp\googletest_ep-prefix\include\gtest/internal/gtest-internal.h(529,33): error C2039: 'TearDownTestSuite': is not a member of 'parquet::ByteArray' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
D:\a\arrow\arrow\cpp\src\parquet/types.h(518): message : see declaration of 'parquet::ByteArray' [D:\a\arrow\arrow\build\cpp\src\parquet\parquet-internals-test.vcxproj]
```
I'll keep looking.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736172872
It seems that the latest GoogleTest doesn't use the default `CMAKE_XXX_OUTPUT_DIRECTORY`: https://github.com/google/googletest/blob/master/googletest/cmake/internal_utils.cmake#L159-L164
Could you try this?
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index df03c3129..e36571808 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1603,21 +1603,16 @@ macro(build_gtest)
set(GTEST_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/googletest_ep-prefix")
set(GTEST_INCLUDE_DIR "${GTEST_PREFIX}/include")
- set(_GTEST_RUNTIME_DIR ${BUILD_OUTPUT_ROOT_DIRECTORY})
+ set(_GTEST_LIBRARY_DIR "${GTEST_PREFIX}/lib")
if(MSVC)
set(_GTEST_IMPORTED_TYPE IMPORTED_IMPLIB)
set(_GTEST_LIBRARY_SUFFIX
"${CMAKE_GTEST_DEBUG_EXTENSION}${CMAKE_IMPORT_LIBRARY_SUFFIX}")
- # Use the import libraries from the EP
- set(_GTEST_LIBRARY_DIR "${GTEST_PREFIX}/lib")
else()
set(_GTEST_IMPORTED_TYPE IMPORTED_LOCATION)
set(_GTEST_LIBRARY_SUFFIX
"${CMAKE_GTEST_DEBUG_EXTENSION}${CMAKE_SHARED_LIBRARY_SUFFIX}")
-
- # Library and runtime same on non-Windows
- set(_GTEST_LIBRARY_DIR "${_GTEST_RUNTIME_DIR}")
endif()
set(GTEST_SHARED_LIB
@@ -1632,6 +1627,7 @@ macro(build_gtest)
${EP_COMMON_TOOLCHAIN}
-DCMAKE_BUILD_TYPE=${CMAKE_BUILD_TYPE}
"-DCMAKE_INSTALL_PREFIX=${GTEST_PREFIX}"
+ -DCMAKE_INSTALL_LIBDIR=lib
-DBUILD_SHARED_LIBS=ON
-DCMAKE_CXX_FLAGS=${GTEST_CMAKE_CXX_FLAGS}
-DCMAKE_CXX_FLAGS_${UPPERCASE_BUILD_TYPE}=${GTEST_CMAKE_CXX_FLAGS})
@@ -1641,27 +1637,6 @@ macro(build_gtest)
set(GTEST_CMAKE_ARGS ${GTEST_CMAKE_ARGS} "-DCMAKE_MACOSX_RPATH:BOOL=ON")
endif()
- if(CMAKE_GENERATOR STREQUAL "Xcode")
- # Xcode projects support multi-configuration builds. This forces the gtest build
- # to use the same output directory as a single-configuration Makefile driven build.
- list(
- APPEND GTEST_CMAKE_ARGS "-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=${_GTEST_LIBRARY_DIR}"
- "-DCMAKE_LIBRARY_OUTPUT_DIRECTORY_${CMAKE_BUILD_TYPE}=${_GTEST_RUNTIME_DIR}")
- endif()
-
- if(MSVC)
- if(NOT ("${CMAKE_GENERATOR}" STREQUAL "Ninja"))
- set(_GTEST_RUNTIME_DIR ${_GTEST_RUNTIME_DIR}/${CMAKE_BUILD_TYPE})
- endif()
- set(GTEST_CMAKE_ARGS
- ${GTEST_CMAKE_ARGS} "-DCMAKE_RUNTIME_OUTPUT_DIRECTORY=${_GTEST_RUNTIME_DIR}"
- "-DCMAKE_RUNTIME_OUTPUT_DIRECTORY_${CMAKE_BUILD_TYPE}=${_GTEST_RUNTIME_DIR}")
- else()
- list(
- APPEND GTEST_CMAKE_ARGS "-DCMAKE_LIBRARY_OUTPUT_DIRECTORY=${_GTEST_RUNTIME_DIR}"
- "-DCMAKE_RUNTIME_OUTPUT_DIRECTORY_${CMAKE_BUILD_TYPE}=${_GTEST_RUNTIME_DIR}")
- endif()
-
add_definitions(-DGTEST_LINKED_AS_SHARED_LIBRARY=1)
if(MSVC AND NOT ARROW_USE_STATIC_CRT)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
arw2019 commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-734530401
I think the code changes here are ok. However, at least some of the build errors look related (and persisted across two CI runs) so that's left to figure out
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
arw2019 commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736241590
Thanks @kou!!! Pushed your suggestions
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736770394
I think so.
We need a fix like https://github.com/apache/arrow/pull/8782#issuecomment-736217882 for `cpp/src/parquet/column_writer_test.cc`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-735722392
Well, at least the ASAN CI job failure seems related:
```
clang: error: no such file or directory: 'debug//libgtestd.so'
```
cc @kou @xhochy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#discussion_r533978049
##########
File path: cpp/src/parquet/encoding_test.cc
##########
@@ -495,7 +488,9 @@ class TestArrowBuilderDecoding : public ::testing::Test {
void CheckDecodeArrowNonNullUsingDenseBuilder() {
for (auto np : null_probabilities_) {
InitTestCase(np);
- SKIP_TEST_IF(null_count_ > 0)
+ if (null_count_ > 0) {
+ GTEST_SKIP();
Review comment:
This should probably be `continue` instead.
##########
File path: cpp/src/parquet/encoding_test.cc
##########
@@ -508,7 +503,9 @@ class TestArrowBuilderDecoding : public ::testing::Test {
void CheckDecodeArrowNonNullUsingDictBuilder() {
for (auto np : null_probabilities_) {
InitTestCase(np);
- SKIP_TEST_IF(null_count_ > 0)
+ if (null_count_ > 0) {
+ GTEST_SKIP();
Review comment:
Same here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] arw2019 commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
arw2019 commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-739702427
Thanks @kou @pitrou !!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou closed pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
kou closed pull request #8782:
URL: https://github.com/apache/arrow/pull/8782
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #8782: ARROW-10746: [C++] Bump gtest version + use GTEST_SKIP in tests
Posted by GitBox <gi...@apache.org>.
kou commented on pull request #8782:
URL: https://github.com/apache/arrow/pull/8782#issuecomment-736217882
It seems that the template type name `T` is conflicted with Visual C++. Could you try this patch?
```diff
diff --git a/cpp/src/parquet/statistics_test.cc b/cpp/src/parquet/statistics_test.cc
index 0828f36b3..77e77e0eb 100644
--- a/cpp/src/parquet/statistics_test.cc
+++ b/cpp/src/parquet/statistics_test.cc
@@ -609,7 +609,7 @@ static const int NUM_VALUES = 10;
template <typename TestType>
class TestStatisticsSortOrder : public ::testing::Test {
public:
- typedef typename TestType::c_type T;
+ using c_type = typename TestType::c_type;
void AddNodes(std::string name) {
fields_.push_back(schema::PrimitiveNode::Make(
@@ -670,7 +670,7 @@ class TestStatisticsSortOrder : public ::testing::Test {
}
protected:
- std::vector<T> values_;
+ std::vector<c_type> values_;
std::vector<uint8_t> values_buf_;
std::vector<schema::NodePtr> fields_;
std::shared_ptr<schema::GroupNode> schema_;
@@ -700,13 +700,13 @@ void TestStatisticsSortOrder<Int32Type>::SetValues() {
// Write UINT32 min/max values
stats_[0]
- .set_min(std::string(reinterpret_cast<const char*>(&values_[5]), sizeof(T)))
- .set_max(std::string(reinterpret_cast<const char*>(&values_[4]), sizeof(T)));
+ .set_min(std::string(reinterpret_cast<const char*>(&values_[5]), sizeof(c_type)))
+ .set_max(std::string(reinterpret_cast<const char*>(&values_[4]), sizeof(c_type)));
// Write INT32 min/max values
stats_[1]
- .set_min(std::string(reinterpret_cast<const char*>(&values_[0]), sizeof(T)))
- .set_max(std::string(reinterpret_cast<const char*>(&values_[9]), sizeof(T)));
+ .set_min(std::string(reinterpret_cast<const char*>(&values_[0]), sizeof(c_type)))
+ .set_max(std::string(reinterpret_cast<const char*>(&values_[9]), sizeof(c_type)));
}
// TYPE::INT64
@@ -728,13 +728,13 @@ void TestStatisticsSortOrder<Int64Type>::SetValues() {
// Write UINT64 min/max values
stats_[0]
- .set_min(std::string(reinterpret_cast<const char*>(&values_[5]), sizeof(T)))
- .set_max(std::string(reinterpret_cast<const char*>(&values_[4]), sizeof(T)));
+ .set_min(std::string(reinterpret_cast<const char*>(&values_[5]), sizeof(c_type)))
+ .set_max(std::string(reinterpret_cast<const char*>(&values_[4]), sizeof(c_type)));
// Write INT64 min/max values
stats_[1]
- .set_min(std::string(reinterpret_cast<const char*>(&values_[0]), sizeof(T)))
- .set_max(std::string(reinterpret_cast<const char*>(&values_[9]), sizeof(T)));
+ .set_min(std::string(reinterpret_cast<const char*>(&values_[0]), sizeof(c_type)))
+ .set_max(std::string(reinterpret_cast<const char*>(&values_[9]), sizeof(c_type)));
}
// TYPE::FLOAT
@@ -747,8 +747,8 @@ void TestStatisticsSortOrder<FloatType>::SetValues() {
// Write Float min/max values
stats_[0]
- .set_min(std::string(reinterpret_cast<const char*>(&values_[0]), sizeof(T)))
- .set_max(std::string(reinterpret_cast<const char*>(&values_[9]), sizeof(T)));
+ .set_min(std::string(reinterpret_cast<const char*>(&values_[0]), sizeof(c_type)))
+ .set_max(std::string(reinterpret_cast<const char*>(&values_[9]), sizeof(c_type)));
}
// TYPE::DOUBLE
@@ -761,8 +761,8 @@ void TestStatisticsSortOrder<DoubleType>::SetValues() {
// Write Double min/max values
stats_[0]
- .set_min(std::string(reinterpret_cast<const char*>(&values_[0]), sizeof(T)))
- .set_max(std::string(reinterpret_cast<const char*>(&values_[9]), sizeof(T)));
+ .set_min(std::string(reinterpret_cast<const char*>(&values_[0]), sizeof(c_type)))
+ .set_max(std::string(reinterpret_cast<const char*>(&values_[9]), sizeof(c_type)));
}
// TYPE::ByteArray
```
Here is a patch to fix CMake lint failure:
```diff
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index bdf15e4bc..46872fba3 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1603,7 +1603,7 @@ macro(build_gtest)
set(GTEST_PREFIX "${CMAKE_CURRENT_BINARY_DIR}/googletest_ep-prefix")
set(GTEST_INCLUDE_DIR "${GTEST_PREFIX}/include")
-set(_GTEST_LIBRARY_DIR "${GTEST_PREFIX}/lib")
+ set(_GTEST_LIBRARY_DIR "${GTEST_PREFIX}/lib")
if(MSVC)
set(_GTEST_IMPORTED_TYPE IMPORTED_IMPLIB)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org