[GitHub] [airflow] criccomini commented on a change in pull request #13980: update BigQueryUpsertTableOperator class to support CMEK

[GitBox <gi...@apache.org>]

criccomini commented on a change in pull request #13980:
URL: https://github.com/apache/airflow/pull/13980#discussion_r571177335



##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1912,8 +1920,11 @@ def __init__(
         self.gcp_conn_id = gcp_conn_id
         self.delegate_to = delegate_to
         self.location = location
+        self.encryption_configuration = encryption_configuration

Review comment:
       I prefer to keep the style as-is, since it mirrors the convention in this class.

##########
File path: airflow/providers/google/cloud/operators/bigquery.py
##########
@@ -1862,6 +1862,13 @@ class BigQueryUpsertTableOperator(BaseOperator):
     :type delegate_to: str
     :param location: The location used for the operation.
     :type location: str
+    :param encryption_configuration: [Optional] Custom encryption configuration (e.g., Cloud KMS keys).

Review comment:
       Nit, use `(Optional)` not `[Optional]` to keep docs consistent.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org