You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2024/08/27 18:58:25 UTC
[PR] Document dynamic destination key should be unique over the pipeline [beam]
Abacn opened a new pull request, #32338:
URL: https://github.com/apache/beam/pull/32338
Document an existing issue #32335
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document dynamic destination key should be unique over the pipeline [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #32338:
URL: https://github.com/apache/beam/pull/32338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document dynamic destination key should be unique over the pipeline [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #32338:
URL: https://github.com/apache/beam/pull/32338#issuecomment-2313299657
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document dynamic destination key should be unique over the pipeline [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #32338:
URL: https://github.com/apache/beam/pull/32338#issuecomment-2313297328
R: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document dynamic destination key should be unique over the pipeline [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #32338:
URL: https://github.com/apache/beam/pull/32338#discussion_r1733400579
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinations.java:
##########
@@ -132,6 +132,10 @@ void setSideInputAccessorFromProcessContext(DoFn<?, ?>.ProcessContext context) {
/**
* Returns an object that represents at a high level which table is being written to. May not
* return null.
+ *
+ * <p>Returned object is expected to be unique for different destination tables involved over all
Review Comment:
Do users implement this method? If so, can we be more prescriptive:
For example:
```
Returned object must be unique for different destination tables involved over all...
```
```
The method must return a unique object for different destination tables involved over all
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document dynamic destination key should be unique over the pipeline [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #32338:
URL: https://github.com/apache/beam/pull/32338#discussion_r1733400579
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinations.java:
##########
@@ -132,6 +132,10 @@ void setSideInputAccessorFromProcessContext(DoFn<?, ?>.ProcessContext context) {
/**
* Returns an object that represents at a high level which table is being written to. May not
* return null.
+ *
+ * <p>Returned object is expected to be unique for different destination tables involved over all
Review Comment:
Do users implement this method? If so, can we be more prescriptive:
For example:
```
Returned object must be unique for different destination tables involved over all...
```
```
The method must return a unique object for different destination tables involved over all...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document dynamic destination key should be unique over the pipeline [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #32338:
URL: https://github.com/apache/beam/pull/32338#discussion_r1733400579
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinations.java:
##########
@@ -132,6 +132,10 @@ void setSideInputAccessorFromProcessContext(DoFn<?, ?>.ProcessContext context) {
/**
* Returns an object that represents at a high level which table is being written to. May not
* return null.
+ *
+ * <p>Returned object is expected to be unique for different destination tables involved over all
Review Comment:
Do users implement this method? If so, can we be more prescriptive:
For example:
```
Returned object must be unique for different destination tables involved over all
The method must return a unique object for different destination tables involved over all
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Document dynamic destination key should be unique over the pipeline [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #32338:
URL: https://github.com/apache/beam/pull/32338#discussion_r1733752817
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/DynamicDestinations.java:
##########
@@ -132,6 +132,10 @@ void setSideInputAccessorFromProcessContext(DoFn<?, ?>.ProcessContext context) {
/**
* Returns an object that represents at a high level which table is being written to. May not
* return null.
+ *
+ * <p>Returned object is expected to be unique for different destination tables involved over all
Review Comment:
thanks for the suggestion, yes, user provides implementation of this abstract class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org