You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mgaido91 <gi...@git.apache.org> on 2018/02/21 13:02:58 UTC
[GitHub] spark pull request #20651: [SPARK-23475][UI] Show also skipped stages
GitHub user mgaido91 opened a pull request:
https://github.com/apache/spark/pull/20651
[SPARK-23475][UI] Show also skipped stages
## What changes were proposed in this pull request?
SPARK-20648 introduced the status `SKIPPED` for the stages. On the UI, previously, skipped stages were shown as `PENDING`; after this change, they are not shown on the UI.
The PR introduce a new section in order to show also `SKIPPED` stages in a proper table.
## How was this patch tested?
manual tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mgaido91/spark SPARK-23475
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/20651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20651
----
commit 5f5d0da2b0f3b41f3c3e73d100820aa6c721e1b7
Author: Marco Gaido <ma...@...>
Date: 2018-02-21T12:37:07Z
[SPARK-23475][UI] Show also skipped stages
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Merged build finished. Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20651
**[Test build #87617 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87617/testReport)** for PR 20651 at commit [`e04bf24`](https://github.com/apache/spark/commit/e04bf24ed0a712aa380de8dd929c7c1d4fdb2990).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20651
@zsxwing SKIPPED stages were previously shown as PENDING. Despite I agree that your fix is needed, I think this is needed too. Do you agree @vanzin?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20651: [SPARK-23475][UI] Show also skipped stages
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20651#discussion_r169734852
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala ---
@@ -172,6 +185,20 @@ private[ui] class AllStagesPage(parent: StagesTab) extends WebUIPage("") {
{completedStagesTable.toNodeSeq}
</div>
}
+ if (shouldShowSkippedStages) {
+ content ++=
+ <span id="skipped" class="collapse-aggregated-allSkippedStages collapse-table"
--- End diff --
I see things like `collapse-aggregated-allCompletedStages` are mentioned in `webui.js`, so probably this one should be added there.
This is kinda past the point where this block should be refactored (it's repeated 5 times now), but probably ok for a 2.3 change.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20651: [SPARK-23475][UI] Show also skipped stages
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/20651
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20651
thanks @vanzin I created the PR for the backport. Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20651
**[Test build #87615 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87615/testReport)** for PR 20651 at commit [`e04bf24`](https://github.com/apache/spark/commit/e04bf24ed0a712aa380de8dd929c7c1d4fdb2990).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20651: [SPARK-23475][UI] Show also skipped stages
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/20651#discussion_r170057919
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala ---
@@ -172,6 +185,20 @@ private[ui] class AllStagesPage(parent: StagesTab) extends WebUIPage("") {
{completedStagesTable.toNodeSeq}
</div>
}
+ if (shouldShowSkippedStages) {
+ content ++=
+ <span id="skipped" class="collapse-aggregated-allSkippedStages collapse-table"
--- End diff --
Sounds good to clean things up in a follow-up.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20651
**[Test build #87617 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87617/testReport)** for PR 20651 at commit [`e04bf24`](https://github.com/apache/spark/commit/e04bf24ed0a712aa380de8dd929c7c1d4fdb2990).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1009/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/1007/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87617/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #20651: [SPARK-23475][UI] Show also skipped stages
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/20651#discussion_r169919844
--- Diff: core/src/main/scala/org/apache/spark/ui/jobs/AllStagesPage.scala ---
@@ -172,6 +185,20 @@ private[ui] class AllStagesPage(parent: StagesTab) extends WebUIPage("") {
{completedStagesTable.toNodeSeq}
</div>
}
+ if (shouldShowSkippedStages) {
+ content ++=
+ <span id="skipped" class="collapse-aggregated-allSkippedStages collapse-table"
--- End diff --
thanks, I added the UT. I think we can create a new JIRA/followup PR to resolve the code redundancy issue you rightly pointed out, what do you think?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20651
Merged to master, but there were conflicts in 2.3; please open a separate PR for the backport.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87615/
Test FAILed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/20651
LGTM, merging to master / 2.3.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20651
**[Test build #87587 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87587/testReport)** for PR 20651 at commit [`5f5d0da`](https://github.com/apache/spark/commit/5f5d0da2b0f3b41f3c3e73d100820aa6c721e1b7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20651
cc @vanzin @zsxwing
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/988/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Merged build finished. Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20651
**[Test build #87615 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87615/testReport)** for PR 20651 at commit [`e04bf24`](https://github.com/apache/spark/commit/e04bf24ed0a712aa380de8dd929c7c1d4fdb2990).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/20651
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/87587/
Test PASSed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by zsxwing <gi...@git.apache.org>.
Github user zsxwing commented on the issue:
https://github.com/apache/spark/pull/20651
@mgaido91 Spark 2.2 doesn't show skipped stages either. I think this is fine since most of people don't care about them. I posted the root cause and fixed in https://github.com/apache/spark/pull/20656
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/20651
**[Test build #87587 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/87587/testReport)** for PR 20651 at commit [`5f5d0da`](https://github.com/apache/spark/commit/5f5d0da2b0f3b41f3c3e73d100820aa6c721e1b7).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #20651: [SPARK-23475][UI] Show also skipped stages
Posted by mgaido91 <gi...@git.apache.org>.
Github user mgaido91 commented on the issue:
https://github.com/apache/spark/pull/20651
Jenkins, retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org