You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "cmccabe (via GitHub)" <gi...@apache.org> on 2023/11/28 21:59:46 UTC
[PR] MINOR: DirectoryId.MIGRATING should be all zeros [kafka]
cmccabe opened a new pull request, #14858:
URL: https://github.com/apache/kafka/pull/14858
DirectoryId.MIGRATING should be all zeros, because all zeros is the default Uuid value in KPRC.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: DirectoryId.MIGRATING should be all zeros [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe merged PR #14858:
URL: https://github.com/apache/kafka/pull/14858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: DirectoryId.MIGRATING should be all zeros [kafka]
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe commented on PR #14858:
URL: https://github.com/apache/kafka/pull/14858#issuecomment-1832693965
> The directory fields in BrokerRegistrationRequest, RegisterBrokerRecord, BrokerRegistrationChangeRecord, PartitionRecord and PartitionChangeRecord are all of type Uuid[], which defaults to an empty list. We don't have any directory related fields of type Uuid in requests or metadata records. But I still think it makes sense to change this, because we might need such fields in the future.
Yeah. Good points.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: DirectoryId.MIGRATING should be all zeros [kafka]
Posted by "rondagostino (via GitHub)" <gi...@apache.org>.
rondagostino commented on code in PR #14858:
URL: https://github.com/apache/kafka/pull/14858#discussion_r1409602400
##########
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##########
@@ -23,25 +23,24 @@
import java.util.Map;
public class DirectoryId {
-
/**
- * A Uuid that is used to identify new or unknown dir assignments.
+ * A Uuid that is used to represent and unspecified log directory,
+ * that is expected to have been previously selected to host an
+ * associated replica. This contrasts with {@code UNASSIGNED_DIR},
+ * which is associated with (typically new) replicas that may not
+ * yet have been placed in any log directory.
*/
- public static final Uuid UNASSIGNED = new Uuid(0L, 0L);
+ public static final Uuid MIGRATING = new Uuid(0L, 0L);
/**
- * A Uuid that is used to represent unspecified offline dirs.
+ * A Uuid that is used to directories that are pending an assignment.
Review Comment:
`s/used to directories/used to represent directories/`
##########
server-common/src/main/java/org/apache/kafka/common/DirectoryId.java:
##########
@@ -23,25 +23,24 @@
import java.util.Map;
public class DirectoryId {
-
/**
- * A Uuid that is used to identify new or unknown dir assignments.
+ * A Uuid that is used to represent and unspecified log directory,
Review Comment:
`s/and/an/` (I know this typo already existed -- we might as well fix it since there is another typo below to fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINOR: DirectoryId.MIGRATING should be all zeros [kafka]
Posted by "soarez (via GitHub)" <gi...@apache.org>.
soarez commented on PR #14858:
URL: https://github.com/apache/kafka/pull/14858#issuecomment-1832632146
The directory fields in `BrokerRegistrationRequest`, `RegisterBrokerRecord`, `BrokerRegistrationChangeRecord`, `PartitionRecord` and `PartitionChangeRecord` are all of type `Uuid[]`, which defaults to an empty list. We don't have any directory related fields of type `Uuid` in requests or metadata records. But I still think it makes sense to change this, because we might need such fields in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org