You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by "uhliarik (via GitHub)" <gi...@apache.org> on 2023/09/27 12:52:08 UTC
[GitHub] [apr] uhliarik opened a new pull request, #46: WIP: lmdb support
uhliarik opened a new pull request, #46:
URL: https://github.com/apache/apr/pull/46
There is still WIP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] notroj commented on pull request #46: WIP: lmdb support
Posted by "notroj (via GitHub)" <gi...@apache.org>.
notroj commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1740939720
Thanks a lot for the contribution, @uhliarik
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] notroj commented on pull request #46: WIP: lmdb support
Posted by "notroj (via GitHub)" <gi...@apache.org>.
notroj commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1738859328
I've tested this with mod_dav and it seems to work well. As well as the changes described above I changed the `_usednames` implementation to pass back the "-lock" file as well:
https://github.com/notroj/apr/commit/26afe6b5b134ef3652bb629e6c68af38317f7f62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] uhliarik commented on pull request #46: WIP: lmdb support
Posted by "uhliarik (via GitHub)" <gi...@apache.org>.
uhliarik commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1737663511
Since I had to rebase this code to the trunk, I'm no longer able to run tests. If anyone can see where I'm missing linking the library, feel free to review the commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] uhliarik commented on pull request #46: WIP: lmdb support
Posted by "uhliarik (via GitHub)" <gi...@apache.org>.
uhliarik commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1738905002
Thanks Joe for reviewing my changes. Previously, I was configurating the lmdb driver with:
```
./configure --with-lmdb --with-dbm=lmdb
```
And I was having troubles with loading lmdb driver as DSO. It was failing during DSO loading phase. I hope there is no issue with this and it is just some configuration thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] minfrin commented on pull request #46: WIP: lmdb support
Posted by "minfrin (via GitHub)" <gi...@apache.org>.
minfrin commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1737357677
Not had a chance to review, but definite +1 in principle.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] notroj commented on pull request #46: WIP: lmdb support
Posted by "notroj (via GitHub)" <gi...@apache.org>.
notroj commented on PR #46:
URL: https://github.com/apache/apr/pull/46#issuecomment-1738652639
With the line marked in my review above removed, and e147886e92b2858895fe9fff30fccf9dba678cad reverted, I can build with:
```sh
"./configure" \
"--with-lmdb" \
"--with-berkeley-db" \
"--with-dbm=db5" \
"--disable-modular-dso"
```
and this passes the tests. Thanks @uhliarik!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] notroj commented on a diff in pull request #46: WIP: lmdb support
Posted by "notroj (via GitHub)" <gi...@apache.org>.
notroj commented on code in PR #46:
URL: https://github.com/apache/apr/pull/46#discussion_r1339682434
##########
build.conf:
##########
@@ -22,6 +22,7 @@ paths =
crypto/crypt_blowfish.c
dbm/apr_dbm_sdbm.c
dbm/apr_dbm.c
+ dbm/apr_dbm_lmdb.c
Review Comment:
This should be removed, the DBM drivers which can be built as DSOs should not be listed here otherwise it will get linked twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apr] asfgit closed pull request #46: WIP: lmdb support
Posted by "asfgit (via GitHub)" <gi...@apache.org>.
asfgit closed pull request #46: WIP: lmdb support
URL: https://github.com/apache/apr/pull/46
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@apr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org