You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/02/10 15:14:13 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
xiaoxiang781216 opened a new pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
URL: https://github.com/apache/incubator-nuttx/pull/245
…enabled
Change-Id: I78510616e68330b0171230ca0e081c0d702a6f42
Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on issue #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
Posted by GitBox <gi...@apache.org>.
jerpelea commented on issue #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
URL: https://github.com/apache/incubator-nuttx/pull/245#issuecomment-584172664
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
URL: https://github.com/apache/incubator-nuttx/pull/245#discussion_r377126936
##########
File path: drivers/net/telnet.c
##########
@@ -308,6 +308,7 @@ static void telnet_check_ctrlchar(FAR struct telnet_dev_s *priv,
}
else
#endif
Review comment:
yes... the diff omits the if at line 315 and makes the logic look crazy. I am merging now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull
request #245: drivers/telnet: Stop the loop if SIGSTP char is match
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match
URL: https://github.com/apache/incubator-nuttx/pull/245#discussion_r377129959
##########
File path: drivers/net/telnet.c
##########
@@ -308,6 +308,7 @@ static void telnet_check_ctrlchar(FAR struct telnet_dev_s *priv,
}
else
#endif
Review comment:
SIGINT has the high priority than SIGSTP, we can't break out immediately if we find SIGSTP char because we may SIGINT char in the later. But if SIGINT isn't enabled, it is safe to break out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
URL: https://github.com/apache/incubator-nuttx/pull/245#discussion_r377127835
##########
File path: drivers/net/telnet.c
##########
@@ -308,6 +308,7 @@ static void telnet_check_ctrlchar(FAR struct telnet_dev_s *priv,
}
else
#endif
Review comment:
@patacongo I can't see that else on 309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo merged pull request #245:
drivers/telnet: Stop the loop if SIGSTP char is match
Posted by GitBox <gi...@apache.org>.
patacongo merged pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match
URL: https://github.com/apache/incubator-nuttx/pull/245
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
URL: https://github.com/apache/incubator-nuttx/pull/245#discussion_r377124983
##########
File path: drivers/net/telnet.c
##########
@@ -308,6 +308,7 @@ static void telnet_check_ctrlchar(FAR struct telnet_dev_s *priv,
}
else
#endif
Review comment:
I don't understand the else here. The else would only be the line "signo = SIGSTP;", right? Wouldn't the "break;" then be executed unconditioinally? Is that the behaviour you want? Code looks wrong.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] patacongo commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
Posted by GitBox <gi...@apache.org>.
patacongo commented on a change in pull request #245: drivers/telnet: Stop the loop if SIGSTP char is match and SIGINT not …
URL: https://github.com/apache/incubator-nuttx/pull/245#discussion_r377125535
##########
File path: drivers/net/telnet.c
##########
@@ -308,6 +308,7 @@ static void telnet_check_ctrlchar(FAR struct telnet_dev_s *priv,
}
else
#endif
Review comment:
Let me look at the source, I might be getting confused by the difference.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services