You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/08 08:00:26 UTC

[GitHub] [dolphinscheduler] zhongjiajie commented on issue #11347: [Feature][Development] Install pre-commit hook automatically and add doc checks

zhongjiajie commented on issue #11347:
URL: https://github.com/apache/dolphinscheduler/issues/11347#issuecomment-1207794491

   Maybe you can see the pre-commit project https://pre-commit.com. But I have had some bad experiences with it, such as:
   * Slow: Obviously, because we have to check locally
   * Update: when `pre-commit-config` file change, development have to update the pre-commit hook, otherwise they will failed in the github action. Also developer have to update both github action and `pre-commit-config` when then change the check rule


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org