You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Tomasz Bech (JIRA)" <de...@myfaces.apache.org> on 2008/11/28 15:49:44 UTC

[jira] Created: (TOMAHAWK-1375) t:selectItems without var causes NullPointerException under Pluto

t:selectItems without var causes NullPointerException under Pluto
-----------------------------------------------------------------

                 Key: TOMAHAWK-1375
                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1375
             Project: MyFaces Tomahawk
          Issue Type: Bug
          Components: Extended SelectItems
    Affects Versions: 1.1.7
         Environment: Pluto
            Reporter: Tomasz Bech


Using t:selectItems without var casues NullPointerException under Pluto.

Stack trace:
java.lang.NullPointerException
	at org.apache.portals.bridges.jsf.AbstractAttributeMap.put(Unknown Source)
	at org.apache.myfaces.custom.selectitems.AbstractUISelectItems.putIteratorToRequestParam(AbstractUISelectItems.java:131)
	at org.apache.myfaces.custom.selectitems.AbstractUISelectItems.createSelectItems(AbstractUISelectItems.java:96)
	at org.apache.myfaces.custom.selectitems.AbstractUISelectItems.getValue(AbstractUISelectItems.java:75)
	at org.apache.myfaces.shared_tomahawk.util.SelectItemsIterator.hasNext(SelectItemsIterator.java:127)
	at org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.internalGetSelectItemList(RendererUtils.java:451)
	at org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.getSelectItemList(RendererUtils.java:429)
	at org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.internalRenderSelect(HtmlRendererUtils.java:303)
	at org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.renderMenu(HtmlRendererUtils.java:276)
	at org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlMenuRendererBase.encodeEnd(HtmlMenuRendererBase.java:59)
	at org.apache.myfaces.renderkit.html.ext.HtmlMenuRenderer.encodeEnd(HtmlMenuRenderer.java:70)

Code:

AbstractUISelectItems.java
    private void putIteratorToRequestParam(Object object) {
        FacesContext.getCurrentInstance().getExternalContext().getRequestMap().put(getVar(), object);
    }

I suppose simple check: if (getVar() != null) should be ok.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (TOMAHAWK-1375) t:selectItems without var causes NullPointerException under Pluto

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/TOMAHAWK-1375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved TOMAHAWK-1375.
--------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.1.10-SNAPSHOT
         Assignee: Leonardo Uribe

Fixed with TOMAHAWK-1403 t:selectItems behaviour with Map values is weird. 

Usually when it is used t:selectItems, var is always set, but if var is not set, the previous behavior (f:selectItems should be preserved)

> t:selectItems without var causes NullPointerException under Pluto
> -----------------------------------------------------------------
>
>                 Key: TOMAHAWK-1375
>                 URL: https://issues.apache.org/jira/browse/TOMAHAWK-1375
>             Project: MyFaces Tomahawk
>          Issue Type: Bug
>          Components: Extended SelectItems
>    Affects Versions: 1.1.7
>         Environment: Pluto
>            Reporter: Tomasz Bech
>            Assignee: Leonardo Uribe
>             Fix For: 1.1.10-SNAPSHOT
>
>
> Using t:selectItems without var casues NullPointerException under Pluto.
> Stack trace:
> java.lang.NullPointerException
> 	at org.apache.portals.bridges.jsf.AbstractAttributeMap.put(Unknown Source)
> 	at org.apache.myfaces.custom.selectitems.AbstractUISelectItems.putIteratorToRequestParam(AbstractUISelectItems.java:131)
> 	at org.apache.myfaces.custom.selectitems.AbstractUISelectItems.createSelectItems(AbstractUISelectItems.java:96)
> 	at org.apache.myfaces.custom.selectitems.AbstractUISelectItems.getValue(AbstractUISelectItems.java:75)
> 	at org.apache.myfaces.shared_tomahawk.util.SelectItemsIterator.hasNext(SelectItemsIterator.java:127)
> 	at org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.internalGetSelectItemList(RendererUtils.java:451)
> 	at org.apache.myfaces.shared_tomahawk.renderkit.RendererUtils.getSelectItemList(RendererUtils.java:429)
> 	at org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.internalRenderSelect(HtmlRendererUtils.java:303)
> 	at org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlRendererUtils.renderMenu(HtmlRendererUtils.java:276)
> 	at org.apache.myfaces.shared_tomahawk.renderkit.html.HtmlMenuRendererBase.encodeEnd(HtmlMenuRendererBase.java:59)
> 	at org.apache.myfaces.renderkit.html.ext.HtmlMenuRenderer.encodeEnd(HtmlMenuRenderer.java:70)
> Code:
> AbstractUISelectItems.java
>     private void putIteratorToRequestParam(Object object) {
>         FacesContext.getCurrentInstance().getExternalContext().getRequestMap().put(getVar(), object);
>     }
> I suppose simple check: if (getVar() != null) should be ok.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.