You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF subversion and git services (JIRA)" <ji...@apache.org> on 2019/05/02 13:41:00 UTC
[jira] [Commented] (WICKET-6657) change replaceAll() to replace()
when a regex is not used
[ https://issues.apache.org/jira/browse/WICKET-6657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16831629#comment-16831629 ]
ASF subversion and git services commented on WICKET-6657:
---------------------------------------------------------
Commit aab8d38348f35e7a164219f5f063bf90cbce9172 in wicket's branch refs/heads/WICKET-6662 from Martin Tzvetanov Grigorov
[ https://gitbox.apache.org/repos/asf?p=wicket.git;h=aab8d38 ]
WICKET-6657 change replaceAll() to replace() when a regex is not used
closes #354
> change replaceAll() to replace() when a regex is not used
> ---------------------------------------------------------
>
> Key: WICKET-6657
> URL: https://issues.apache.org/jira/browse/WICKET-6657
> Project: Wicket
> Issue Type: Improvement
> Reporter: bd2019us
> Assignee: Martin Grigorov
> Priority: Trivial
> Labels: pull-request-available
> Fix For: 9.0.0-M2
>
> Attachments: WICKET-6657.patch
>
>
> When a regex is not used, replace() is more optimal than replaceAll() because replaceAll() has extra performance overhead from attempting to compile the unused regex
> Affected file:
> * wicket-util/src/main/java/org/apache/wicket/util/lang/Args.java
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)