You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@libcloud.apache.org by "zhechen-cs (via GitHub)" <gi...@apache.org> on 2026/10/17 18:32:21 UTC
[PR] Run the initial request with a nonpositive retry timeout [libcloud]
zhechen-cs opened a new pull request, #2199:
URL: https://github.com/apache/libcloud/pull/2199
### Description
Always run the initial request in `MinimalRetry` and `Retry`, including when the timeout is zero or negative. Previously these values skipped the request and raised an unrelated `TypeError` from `raise None`.
If the request fails after the deadline, propagate its exception without sleeping. Regression tests cover both retry classes, successful results, retryable connection and rate-limit errors, and non-retryable errors.
Fixes https://github.com/apache/libcloud/issues/2198
### Status
Ready for review.
### Validation
- Common, connection, utility and HTTP tests: 213 passed, 1 skipped, 16 subtests passed (Python 3.12; `NO_INTERNET=1`, loopback proxy bypass).
- New regressions fail on the unmodified production code.
- Black, isort, flake8, pylint and `git diff --check` pass for the changed files.
- The full provider matrix and live cloud integration tests were not run.
### Checklist
- [x] Code linting
- [ ] Documentation (no public API change)
- [x] Tests
- [ ] ICLA (small bug fix)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@libcloud.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org