You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Julian Foad <ju...@btopenworld.com> on 2009/10/09 23:35:29 UTC
Re: svn commit: r39905 - trunk/subversion/tests/cmdline
Daniel Shahaf wrote:
> Author: danielsh
> Date: Fri Oct 9 13:16:05 2009
> New Revision: 39905
>
> Log:
> Moving a file should preserve its changelist. Add tests to this effect.
>
> * subversion/tests/cmdline/changelist_tests.py
> (move_keeps_changelist, move_added_keeps_changelist):
> New tests.
> (test_list):
> Run them, XFail.
In that case, "copy" should preserve the changelist on the copy too. I
don't know whether it does, just saying.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405724
Re: svn commit: r39905 - trunk/subversion/tests/cmdline
Posted by Julian Foad <ju...@btopenworld.com>.
On Sat, 2009-10-10 at 12:46 +0100, Stefan Sperling wrote:
> On Sat, Oct 10, 2009 at 01:25:49PM +0200, Daniel Shahaf wrote:
> > Julian Foad wrote on Sat, 10 Oct 2009 at 02:24 +0100:
> > > Greg Stein wrote:
> > > > On Fri, Oct 9, 2009 at 19:35, Julian Foad wrote:
> > > > > Daniel Shahaf wrote:
> > > > >> Log:
> > > > >> Moving a file should preserve its changelist. Add tests to this effect.
> > > > >
> > > > > In that case, "copy" should preserve the changelist on the copy too. I
> > > > > don't know whether it does, just saying.
> > > >
> > > > I'm not sure that I agree.
> > > >
> > > > The changelist is associated with the specific node, so (IMO) it
> > > > should move along with it.
> > > >
> > > > I don't see how a copy implies any similar kind of movement or
> > > > extension of the changelist.
> > >
> > > I suppose it depends on what kind of change you are tracking. I was
> > > thinking of a whole new file for feature X, and that if I copy it then
> > > it's likely that the copy is part of my feature X too. But if I'd just
> > > made a small text change in X and then copied it, I'm probably wanting
> > > the copy for some completely different purpose.
> > >
> >
> > It's (IMO) easier for users to remove the changelist if it follows the
> > copy than to remember to add it manually else. But I'm not convinced
> > either way yet.
>
> There are two possible and valid use cases here, so we should support both.
Yes, ...
> I agree that keeping changelist info on the copy by default is fine.
> But a new flag such as --ignore-changelist for svn 'move' and 'svn copy'
> to complement the default behaviour would be nice.
... but not necessarily by adding yet another switch. If the alternate
behaviour is less common and can be achieved in an obvious and easy way
using existing commands then that would be sufficient.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2407168
Re: svn commit: r39905 - trunk/subversion/tests/cmdline
Posted by Stefan Sperling <st...@elego.de>.
On Sat, Oct 10, 2009 at 01:25:49PM +0200, Daniel Shahaf wrote:
> Julian Foad wrote on Sat, 10 Oct 2009 at 02:24 +0100:
> > Greg Stein wrote:
> > > On Fri, Oct 9, 2009 at 19:35, Julian Foad wrote:
> > > > Daniel Shahaf wrote:
> > > >> Log:
> > > >> Moving a file should preserve its changelist. Add tests to this effect.
> > > >
> > > > In that case, "copy" should preserve the changelist on the copy too. I
> > > > don't know whether it does, just saying.
> > >
> > > I'm not sure that I agree.
> > >
> > > The changelist is associated with the specific node, so (IMO) it
> > > should move along with it.
> > >
> > > I don't see how a copy implies any similar kind of movement or
> > > extension of the changelist.
> >
> > I suppose it depends on what kind of change you are tracking. I was
> > thinking of a whole new file for feature X, and that if I copy it then
> > it's likely that the copy is part of my feature X too. But if I'd just
> > made a small text change in X and then copied it, I'm probably wanting
> > the copy for some completely different purpose.
> >
>
> It's (IMO) easier for users to remove the changelist if it follows the
> copy than to remember to add it manually else. But I'm not convinced
> either way yet.
There are two possible and valid use cases here, so we should support both.
I agree that keeping changelist info on the copy by default is fine.
But a new flag such as --ignore-changelist for svn 'move' and 'svn copy'
to complement the default behaviour would be nice.
This problem reminds me of my recent work on 'svn diff' -- there are
two ways to diff copied files: against their source, or like a newly
added file. Both use cases occur in practice. Yet for some reason svn only
supported the former use case (and still does for anything but WC->WC diffs
but I hope to fix this soon).
It does not matter what the default behaviour is, but it should at least
be possible for users to tickle the alternative behaviour out of svn easily.
Otherwise it hurts the user experience.
Stefan
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405841
Re: svn commit: r39905 - trunk/subversion/tests/cmdline
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Julian Foad wrote on Sat, 10 Oct 2009 at 02:24 +0100:
> Greg Stein wrote:
> > On Fri, Oct 9, 2009 at 19:35, Julian Foad wrote:
> > > Daniel Shahaf wrote:
> > >> Log:
> > >> Moving a file should preserve its changelist. Add tests to this effect.
> > >
> > > In that case, "copy" should preserve the changelist on the copy too. I
> > > don't know whether it does, just saying.
> >
> > I'm not sure that I agree.
> >
> > The changelist is associated with the specific node, so (IMO) it
> > should move along with it.
> >
> > I don't see how a copy implies any similar kind of movement or
> > extension of the changelist.
>
> I suppose it depends on what kind of change you are tracking. I was
> thinking of a whole new file for feature X, and that if I copy it then
> it's likely that the copy is part of my feature X too. But if I'd just
> made a small text change in X and then copied it, I'm probably wanting
> the copy for some completely different purpose.
>
It's (IMO) easier for users to remove the changelist if it follows the
copy than to remember to add it manually else. But I'm not convinced
either way yet.
Daniel
> Actually, I also said what I said because I was thinking around the idea
> that object identity should kind of follow the content, so both the
> original and the copy have equal successorship status ... but that's in
> the realm of thought experiments and not Subversion.
>
> - Julian
>
> ------------------------------------------------------
> http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405743
>
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405837
Re: svn commit: r39905 - trunk/subversion/tests/cmdline
Posted by Julian Foad <ju...@btopenworld.com>.
Greg Stein wrote:
> On Fri, Oct 9, 2009 at 19:35, Julian Foad wrote:
> > Daniel Shahaf wrote:
> >> Author: danielsh
> >> Date: Fri Oct 9 13:16:05 2009
> >> New Revision: 39905
> >>
> >> Log:
> >> Moving a file should preserve its changelist. Add tests to this effect.
> >>
> >> * subversion/tests/cmdline/changelist_tests.py
> >> (move_keeps_changelist, move_added_keeps_changelist):
> >> New tests.
> >> (test_list):
> >> Run them, XFail.
> >
> > In that case, "copy" should preserve the changelist on the copy too. I
> > don't know whether it does, just saying.
>
> I'm not sure that I agree.
>
> The changelist is associated with the specific node, so (IMO) it
> should move along with it.
>
> I don't see how a copy implies any similar kind of movement or
> extension of the changelist.
I suppose it depends on what kind of change you are tracking. I was
thinking of a whole new file for feature X, and that if I copy it then
it's likely that the copy is part of my feature X too. But if I'd just
made a small text change in X and then copied it, I'm probably wanting
the copy for some completely different purpose.
Actually, I also said what I said because I was thinking around the idea
that object identity should kind of follow the content, so both the
original and the copy have equal successorship status ... but that's in
the realm of thought experiments and not Subversion.
- Julian
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405743
Re: svn commit: r39905 - trunk/subversion/tests/cmdline
Posted by Greg Stein <gs...@gmail.com>.
On Fri, Oct 9, 2009 at 19:35, Julian Foad <ju...@btopenworld.com> wrote:
> Daniel Shahaf wrote:
>> Author: danielsh
>> Date: Fri Oct 9 13:16:05 2009
>> New Revision: 39905
>>
>> Log:
>> Moving a file should preserve its changelist. Add tests to this effect.
>>
>> * subversion/tests/cmdline/changelist_tests.py
>> (move_keeps_changelist, move_added_keeps_changelist):
>> New tests.
>> (test_list):
>> Run them, XFail.
>
> In that case, "copy" should preserve the changelist on the copy too. I
> don't know whether it does, just saying.
I'm not sure that I agree.
The changelist is associated with the specific node, so (IMO) it
should move along with it.
I don't see how a copy implies any similar kind of movement or
extension of the changelist.
Cheers,
-g
------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2405737