[GitHub] qpid-proton issue #128: PROTON-1342: CI on OS X

[astitcher <gi...@git.apache.org>]

Github user astitcher commented on the issue:

    https://github.com/apache/qpid-proton/pull/128
  
    A few points - 
    * I'm not sure how familiar you are with git/github: but there seem to be a lot of fairly meaningless changes here. Could you squash all of these changes into a single change. That would make it easier to see what's actually changed.
    * I think you've introduced way too many builds to the CI - do we really need to build every possible version of Xcode? I'd prefer to pick just the current and earliest supported version - that should suffice for CI, shouldn't it?
    * I don't think you need to introduce a conditional to the before_script. The purpose of the QPID_PROTON_CMAKE_ARGS variable is to change exactly what you are changing - I think you can set it for the new matrix elements you are introducing.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org