You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Cheng Lian (JIRA)" <ji...@apache.org> on 2014/05/01 17:47:17 UTC

[jira] [Created] (SPARK-1694) Simplify ColumnBuilder/Accessor class hierarchy

Cheng Lian created SPARK-1694:
---------------------------------

             Summary: Simplify ColumnBuilder/Accessor class hierarchy
                 Key: SPARK-1694
                 URL: https://issues.apache.org/jira/browse/SPARK-1694
             Project: Spark
          Issue Type: Improvement
          Components: SQL
    Affects Versions: 1.0.0
            Reporter: Cheng Lian
            Assignee: Cheng Lian
             Fix For: 1.1.0


Current {{ColumnBuilder/Accessor}} class hierarchy design was largely refactored from the in-memory columnar storage component of Shark. Code related to null values and compression were factored into {{NullableColumnBuilder/Accessor}} and {{CompressibleColumnBuilder/Accessor}} and then mixed in as stackable traits. The drawback is:

# Interactions among these classes were unnecessarily complicated and error prone.
# Flexibility provided by this design now seems useless

To simplify this, we can merge {{CompressibleColumnBuilder/Accessor}} and {{NullableColumnBuilder/Accessor}} into {{NativeColumnBuilder/Accessor}}, simply hard code null value processing and compression logic together.



--
This message was sent by Atlassian JIRA
(v6.2#6252)