You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/12/08 20:23:10 UTC

[jira] [Commented] (FLINK-3147) HadoopOutputFormatBase should expose fields as protected

    [ https://issues.apache.org/jira/browse/FLINK-3147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15047320#comment-15047320 ] 

ASF GitHub Bot commented on FLINK-3147:
---------------------------------------

Github user ndimiduk commented on the pull request:

    https://github.com/apache/flink/pull/1442#issuecomment-162987985
  
    I pushed an updated change to the same branch, not sure why the PR didn't pick it up. https://github.com/ndimiduk/flink/commit/333aa03fe7f509fd2dff6f56476d7ba4b3da6289


> HadoopOutputFormatBase should expose fields as protected
> --------------------------------------------------------
>
>                 Key: FLINK-3147
>                 URL: https://issues.apache.org/jira/browse/FLINK-3147
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: Nick Dimiduk
>            Priority: Minor
>
> While adopting PhoenixOutputFormat to a streaming job, I find that the implementation of {{HadoopOutputFormatBase#close}} is not relevant when there's no temp file to move. However, subclasses cannot effectively override implementation because {{CLOSE_MUTEX}} is marked private.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)