You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/02/23 04:33:00 UTC
[GitHub] [pulsar] MarvinCai opened a new pull request #9678: Revert "Avoid enable DLQ on Key_Shared subscription. (#9163)"
MarvinCai opened a new pull request #9678:
URL: https://github.com/apache/pulsar/pull/9678
As discussed in https://github.com/apache/pulsar/pull/9583, Key_Shared is not all about ordering, so we'll still enable use of DLQ but adding document to warning user about the consequence of using negative ack and DQL for ordered sub type.
This reverts commit 9af857781fc3d357834eaa13acf45005f8186875.
https://github.com/apache/pulsar/commit/9af857781fc3d357834eaa13acf45005f8186875
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #9678: Revert "Avoid enable DLQ on Key_Shared subscription. (#9163)"
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #9678:
URL: https://github.com/apache/pulsar/pull/9678#issuecomment-784440381
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #9678: Revert "Avoid enable DLQ on Key_Shared subscription. (#9163)"
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #9678:
URL: https://github.com/apache/pulsar/pull/9678#issuecomment-783942140
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] MarvinCai commented on pull request #9678: Revert "Avoid enable DLQ on Key_Shared subscription. (#9163)"
Posted by GitBox <gi...@apache.org>.
MarvinCai commented on pull request #9678:
URL: https://github.com/apache/pulsar/pull/9678#issuecomment-783977135
@codelipenghui please take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] sijie merged pull request #9678: Revert "Avoid enable DLQ on Key_Shared subscription. (#9163)"
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #9678:
URL: https://github.com/apache/pulsar/pull/9678
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org