You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/11/20 16:22:41 UTC

[GitHub] [flink] kl0u opened a new pull request #14157: [FLINK-19969] CLI print run-application help msg

kl0u opened a new pull request #14157:
URL: https://github.com/apache/flink/pull/14157


   ## What is the purpose of the change
   
   Adds a help message for the `run-application` CLI command.
   
   ## Brief change log
   
   The main change is in the `CliFrontendParser.printHelpForRunApplication()`.
   
   ## Verifying this change
   
   Build Flink and run from the CLI: `run-application -h`
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731267534


   Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
   to review your pull request. We will use this comment to track the progress of the review.
   
   
   ## Automated Checks
   Last check on commit 14d6e11c4a97f05f743d24760654633ee04ff841 (Fri Nov 20 16:25:05 UTC 2020)
   
   **Warnings:**
    * No documentation files were touched! Remember to keep the Flink docs up to date!
   
   
   <sub>Mention the bot in a comment to re-run the automated checks.</sub>
   ## Review Progress
   
   * ❓ 1. The [description] looks good.
   * ❓ 2. There is [consensus] that the contribution should go into to Flink.
   * ❓ 3. Needs [attention] from.
   * ❓ 4. The change fits into the overall [architecture].
   * ❓ 5. Overall code [quality] is good.
   
   Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
    The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
    - `@flinkbot approve all` to approve all aspects
    - `@flinkbot approve-until architecture` to approve everything until `architecture`
    - `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
    - `@flinkbot disapprove architecture` to remove an approval you gave earlier
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254",
       "triggerID" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14d6e11c4a97f05f743d24760654633ee04ff841 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884) 
   * f8b909654df226298fd5f5c21ece16ebb55d5ea1 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] kl0u commented on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
kl0u commented on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-734780539


   @aljoscha I pushed another solution that mitigates the problems you mentioned. Let me know what you think.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14d6e11c4a97f05f743d24760654633ee04ff841 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254",
       "triggerID" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "caeef2396d8bca4929f38d36ecf0d4b9a5ee8224",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "caeef2396d8bca4929f38d36ecf0d4b9a5ee8224",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f8b909654df226298fd5f5c21ece16ebb55d5ea1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254) 
   * caeef2396d8bca4929f38d36ecf0d4b9a5ee8224 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254",
       "triggerID" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "caeef2396d8bca4929f38d36ecf0d4b9a5ee8224",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10347",
       "triggerID" : "caeef2396d8bca4929f38d36ecf0d4b9a5ee8224",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * caeef2396d8bca4929f38d36ecf0d4b9a5ee8224 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10347) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14d6e11c4a97f05f743d24760654633ee04ff841 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on a change in pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r532492542



##########
File path: flink-clients/src/main/java/org/apache/flink/client/deployment/ClusterClientFactory.java
##########
@@ -62,4 +62,13 @@
 	 * @return the corresponding {@link ClusterSpecification} for a new Flink cluster
 	 */
 	ClusterSpecification getClusterSpecification(Configuration configuration);
+
+	/**
+	 * Returns the option to be used when trying to execute an application in Application Mode
+	 * using this cluster client factory, or an empty string if the environment of this cluster client
+	 * factory does not support Application Mode.
+	 */
+	default String getApplicationTargetName() {

Review comment:
       This could be `Optional<String>`. Even in this PR you're returning `null` in `DummyClusterClientServiceLoader`, which could then be `Optional.empty()`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254",
       "triggerID" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f8b909654df226298fd5f5c21ece16ebb55d5ea1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14d6e11c4a97f05f743d24760654633ee04ff841 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884) 
   * f8b909654df226298fd5f5c21ece16ebb55d5ea1 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on a change in pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r528589245



##########
File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -371,6 +372,18 @@ public static void printHelpForRun(Collection<CustomCommandLine> customCommandLi
 		System.out.println();
 	}
 
+	public static void printHelpForRunApplication() {
+		HelpFormatter formatter = new HelpFormatter();
+		formatter.setLeftPadding(5);
+		formatter.setWidth(80);
+
+		System.out.println("\nAction \"run-application\" runs an application in Application Mode.");
+		System.out.println("\n  Syntax: run-application -t [kubernetes-application, yarn-application] [OPTIONS] <jar-file> <arguments>");

Review comment:
       No, unfortunately I think we need the `run-application` because it can't be implemented as "just an executor".
   
   Why wouldn't it work with service discovery? I know that right now there is nothing that we could load that could report the name but we could add sth? I just doesn't feel very extensible to have the names hardcoded here. 😅 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] kl0u commented on a change in pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r528578010



##########
File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -371,6 +372,18 @@ public static void printHelpForRun(Collection<CustomCommandLine> customCommandLi
 		System.out.println();
 	}
 
+	public static void printHelpForRunApplication() {
+		HelpFormatter formatter = new HelpFormatter();
+		formatter.setLeftPadding(5);
+		formatter.setWidth(80);
+
+		System.out.println("\nAction \"run-application\" runs an application in Application Mode.");
+		System.out.println("\n  Syntax: run-application -t [kubernetes-application, yarn-application] [OPTIONS] <jar-file> <arguments>");

Review comment:
       For the `-t` I put them here because these are the only valid options for `run-application`. The rest are not compatible with the `run-application` command.
   
   The reason for hardcoding the `foo-application` is a combination of what you said, and also the package structure of the project that makes it impossible to find all available executors without service discovery.
   
   Now for the separation, you mean that we should not have a separate command (like `run-application`) or something else?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot edited a comment on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "DELETED",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=9884",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     }, {
       "hash" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254",
       "triggerID" : "f8b909654df226298fd5f5c21ece16ebb55d5ea1",
       "triggerType" : "PUSH"
     }, {
       "hash" : "caeef2396d8bca4929f38d36ecf0d4b9a5ee8224",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10347",
       "triggerID" : "caeef2396d8bca4929f38d36ecf0d4b9a5ee8224",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f8b909654df226298fd5f5c21ece16ebb55d5ea1 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10254) 
   * caeef2396d8bca4929f38d36ecf0d4b9a5ee8224 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=10347) 
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] kl0u commented on a change in pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
kl0u commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r528592226



##########
File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -371,6 +372,18 @@ public static void printHelpForRun(Collection<CustomCommandLine> customCommandLi
 		System.out.println();
 	}
 
+	public static void printHelpForRunApplication() {
+		HelpFormatter formatter = new HelpFormatter();
+		formatter.setLeftPadding(5);
+		formatter.setWidth(80);
+
+		System.out.println("\nAction \"run-application\" runs an application in Application Mode.");
+		System.out.println("\n  Syntax: run-application -t [kubernetes-application, yarn-application] [OPTIONS] <jar-file> <arguments>");

Review comment:
       For the `run-application` I agree, and this would be my answer actually if you suggested to use the `run` for everything :)
   
   I agree also about the extensibility for the general help message of the `-t`. I may need to think though how to add it. For the `run-application` though, we should still hardcode it because we want to say that the user can only use a subset of the available executors with this command. WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] kl0u closed pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
kl0u closed pull request #14157:
URL: https://github.com/apache/flink/pull/14157


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] flinkbot commented on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-731272625


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "14d6e11c4a97f05f743d24760654633ee04ff841",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 14d6e11c4a97f05f743d24760654633ee04ff841 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run travis` re-run the last Travis build
    - `@flinkbot run azure` re-run the last Azure build
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] aljoscha commented on a change in pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
aljoscha commented on a change in pull request #14157:
URL: https://github.com/apache/flink/pull/14157#discussion_r528574208



##########
File path: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontendParser.java
##########
@@ -371,6 +372,18 @@ public static void printHelpForRun(Collection<CustomCommandLine> customCommandLi
 		System.out.println();
 	}
 
+	public static void printHelpForRunApplication() {
+		HelpFormatter formatter = new HelpFormatter();
+		formatter.setLeftPadding(5);
+		formatter.setWidth(80);
+
+		System.out.println("\nAction \"run-application\" runs an application in Application Mode.");
+		System.out.println("\n  Syntax: run-application -t [kubernetes-application, yarn-application] [OPTIONS] <jar-file> <arguments>");

Review comment:
       I think these would come from the description of the `-t` parameter, right?
   
   I also noticed that we're hardcoding the `foo-application` targets/executors because they are not real executors. That doesn't seem right.
   
   Maybe it was a mistake how we separated job/session/application. "Job" and "session" are executors, while "application" is a whole different mode. 🙈 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [flink] tillrohrmann commented on pull request #14157: [FLINK-19969] CLI print run-application help msg

Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on pull request #14157:
URL: https://github.com/apache/flink/pull/14157#issuecomment-734803175


   cc @rmetzger because we are currently also reworking the deployment documentation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org