You are viewing a plain text version of this content. The canonical link for it is here.
Posted to builds@apache.org by Flavio Junqueira <fp...@apache.org> on 2016/11/04 12:11:14 UTC
Findbugs
Has there been any changes to windbags recently? Recently being the last day or two.
Thanks,
-Flavio
Re: Findbugs
Posted by Flavio Junqueira <fp...@apache.org>.
Thank you all for the information, it was very useful.
-Flavio
> On 04 Nov 2016, at 22:31, Gavin McDonald <ga...@16degrees.com.au> wrote:
>
>>
>> On 5 Nov. 2016, at 1:03 am, Flavio Junqueira <fpj@apache.org <ma...@apache.org>> wrote:
>>
>> Clearly I was trying to say findbugs but my spell-checker disagreed with me.
>>
>> Here is an example:
>>
>> https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-Build/3512/
>>
>> which fails with:
>>
>> BUILD FAILED
>> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580: 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of Findbugs installation> to Ant on the command-line.
>>
>> and we are defining the variable like this in the confguration:
>>
>> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest
>>
>> Also, in this other queue got pull requests:
>>
>> https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-github-pr-build/35/ <https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-github-pr-build/35/><https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-github-pr-build/35/ <https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-github-pr-build/35/>>
>>
>> I got this:
>>
>> -1 findbugs. The patch appears to introduce 19 new Findbugs (version 3.0.1) warnings.
>>
>> and I should be really getting no new warning because it is a shell script I'm adding and there is nothing that has changed that I'm aware of.
>>
>> These two cases made me suspect that something changed with the findbugs installation, but you tell me if that's the case or not.
>
> Ok yes I upgraded Findbugs to 3.0.1
>
> Latest symlink was changed to point to that version.
>
> Maybe try changing from ‘latest’ to findbugs-2.0.3 and see if that ‘fixes’ things. (If so then for you, using the latest Findbugs has found
> some problems?)
>
> Or, your build was caught in the middle cf the upgrade and things will work just fine now.
>
> Gav…
>
>>
>> -Flavio
>>
>>> On 04 Nov 2016, at 13:50, Pono Takamori <pono@apache.org <ma...@apache.org>> wrote:
>>>
>>> A link to a failing job would be great.
>>>
>>> Cheers
>>> -Pono
>>>
>>> On Fri, Nov 4, 2016 at 1:11 PM, Flavio Junqueira <fpj@apache.org <ma...@apache.org>> wrote:
>>>> Has there been any changes to windbags recently? Recently being the last day or two.
>>>>
>>>> Thanks,
>>>> -Flavio
Re: Findbugs
Posted by Gavin McDonald <ga...@16degrees.com.au>.
> On 5 Nov. 2016, at 1:03 am, Flavio Junqueira <fp...@apache.org> wrote:
>
> Clearly I was trying to say findbugs but my spell-checker disagreed with me.
>
> Here is an example:
>
> https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-Build/3512/
>
> which fails with:
>
> BUILD FAILED
> /home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580: 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of Findbugs installation> to Ant on the command-line.
>
> and we are defining the variable like this in the confguration:
>
> -Dfindbugs.home=/home/jenkins/tools/findbugs/latest
>
> Also, in this other queue got pull requests:
>
> https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-github-pr-build/35/ <https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-github-pr-build/35/>
>
> I got this:
>
> -1 findbugs. The patch appears to introduce 19 new Findbugs (version 3.0.1) warnings.
>
> and I should be really getting no new warning because it is a shell script I'm adding and there is nothing that has changed that I'm aware of.
>
> These two cases made me suspect that something changed with the findbugs installation, but you tell me if that's the case or not.
Ok yes I upgraded Findbugs to 3.0.1
Latest symlink was changed to point to that version.
Maybe try changing from ‘latest’ to findbugs-2.0.3 and see if that ‘fixes’ things. (If so then for you, using the latest Findbugs has found
some problems?)
Or, your build was caught in the middle cf the upgrade and things will work just fine now.
Gav…
>
> -Flavio
>
>> On 04 Nov 2016, at 13:50, Pono Takamori <po...@apache.org> wrote:
>>
>> A link to a failing job would be great.
>>
>> Cheers
>> -Pono
>>
>> On Fri, Nov 4, 2016 at 1:11 PM, Flavio Junqueira <fp...@apache.org> wrote:
>>> Has there been any changes to windbags recently? Recently being the last day or two.
>>>
>>> Thanks,
>>> -Flavio
>
Re: Findbugs
Posted by Allen Wittenauer <aw...@effectivemachines.com>.
> On Nov 4, 2016, at 7:03 AM, Flavio Junqueira <fp...@apache.org> wrote:
>
> and I should be really getting no new warning because it is a shell script I'm adding and there is nothing that has changed that I'm aware of.
FWIW, there are a few race conditions in pre-Yetus test-patch that could generate that type of output.
Re: Findbugs
Posted by Flavio Junqueira <fp...@apache.org>.
Clearly I was trying to say findbugs but my spell-checker disagreed with me.
Here is an example:
https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-Build/3512/
which fails with:
BUILD FAILED
/home/jenkins/jenkins-slave/workspace/PreCommit-ZOOKEEPER-Build/build.xml:1580: 'findbugs.home' is not defined. Please pass -Dfindbugs.home=<base of Findbugs installation> to Ant on the command-line.
and we are defining the variable like this in the confguration:
-Dfindbugs.home=/home/jenkins/tools/findbugs/latest
Also, in this other queue got pull requests:
https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-github-pr-build/35/ <https://builds.apache.org/view/PreCommit%20Builds/job/PreCommit-ZOOKEEPER-github-pr-build/35/>
I got this:
-1 findbugs. The patch appears to introduce 19 new Findbugs (version 3.0.1) warnings.
and I should be really getting no new warning because it is a shell script I'm adding and there is nothing that has changed that I'm aware of.
These two cases made me suspect that something changed with the findbugs installation, but you tell me if that's the case or not.
-Flavio
> On 04 Nov 2016, at 13:50, Pono Takamori <po...@apache.org> wrote:
>
> A link to a failing job would be great.
>
> Cheers
> -Pono
>
> On Fri, Nov 4, 2016 at 1:11 PM, Flavio Junqueira <fp...@apache.org> wrote:
>> Has there been any changes to windbags recently? Recently being the last day or two.
>>
>> Thanks,
>> -Flavio
Re: Findbugs
Posted by Pono Takamori <po...@apache.org>.
A link to a failing job would be great.
Cheers
-Pono
On Fri, Nov 4, 2016 at 1:11 PM, Flavio Junqueira <fp...@apache.org> wrote:
> Has there been any changes to windbags recently? Recently being the last day or two.
>
> Thanks,
> -Flavio