You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2015/04/08 18:55:24 UTC
Review Request 32981: Some service components are missing from API
response and causes problems
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32981/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Sid Wagle.
Bugs: AMBARI-10405
https://issues.apache.org/jira/browse/AMBARI-10405
Repository: ambari
Description
-------
We have a situation where service components that have been installed and previously working have disappeared from the API response.
/api/v1/clusters/cluster_name/services/YARN/components does NOT return NODEMANAGER
/api/v1/clusters/cluster_name/services/STORM/components does NOT return SUPERVISOR
Note that Ambari Server shows an ERROR when loading these service components, but the server continues the startup sequence.
Ambari Web is even usable and you can login, but the YARN and STORM service summary panels show invalid info (and other operations fail, since the server thinks these service components don't even exist).
Ambari DB consistency should be check during ambari-server start
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 7ea96be
version 6a4bfb9
Diff: https://reviews.apache.org/r/32981/diff/
Testing
-------
manual tests on corrupted DB's
Thanks,
Dmytro Sen
Re: Review Request 32981: Some service components are missing from API
response and causes problems
Posted by Dmytro Sen <ds...@hortonworks.com>.
> On Апрель 8, 2015, 5:17 п.п., Alejandro Fernandez wrote:
> > version, line 1
> > <https://reviews.apache.org/r/32981/diff/1/?file=920952#file920952line1>
> >
> > Why does this need to change as opposed to getting value from pom file?
I've add this change to patch accidentally.
> On Апрель 8, 2015, 5:17 п.п., Alejandro Fernandez wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, line 223
> > <https://reviews.apache.org/r/32981/diff/1/?file=920951#file920951line223>
> >
> > This will make the start process slower. Can we instead do this on-demand? And move it to its own class, especially if we decide to add more features to this checker.
It doesn't make the start process slower. It's only less than 1 second longer on my laptop, checking server DB for cluster with 1000 nodes and 15 services. Moved this check into the separate class
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32981/#review79377
-----------------------------------------------------------
On Апрель 8, 2015, 4:55 п.п., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32981/
> -----------------------------------------------------------
>
> (Updated Апрель 8, 2015, 4:55 п.п.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
>
>
> Bugs: AMBARI-10405
> https://issues.apache.org/jira/browse/AMBARI-10405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have a situation where service components that have been installed and previously working have disappeared from the API response.
> /api/v1/clusters/cluster_name/services/YARN/components does NOT return NODEMANAGER
> /api/v1/clusters/cluster_name/services/STORM/components does NOT return SUPERVISOR
> Note that Ambari Server shows an ERROR when loading these service components, but the server continues the startup sequence.
> Ambari Web is even usable and you can login, but the YARN and STORM service summary panels show invalid info (and other operations fail, since the server thinks these service components don't even exist).
> Ambari DB consistency should be check during ambari-server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 7ea96be
> version 6a4bfb9
>
> Diff: https://reviews.apache.org/r/32981/diff/
>
>
> Testing
> -------
>
> manual tests on corrupted DB's
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 32981: Some service components are missing from API
response and causes problems
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32981/#review79377
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
<https://reviews.apache.org/r/32981/#comment128653>
This will make the start process slower. Can we instead do this on-demand? And move it to its own class, especially if we decide to add more features to this checker.
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
<https://reviews.apache.org/r/32981/#comment128654>
Great idea for this checker :-)
version
<https://reviews.apache.org/r/32981/#comment128652>
Why does this need to change as opposed to getting value from pom file?
- Alejandro Fernandez
On April 8, 2015, 4:55 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32981/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 4:55 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
>
>
> Bugs: AMBARI-10405
> https://issues.apache.org/jira/browse/AMBARI-10405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have a situation where service components that have been installed and previously working have disappeared from the API response.
> /api/v1/clusters/cluster_name/services/YARN/components does NOT return NODEMANAGER
> /api/v1/clusters/cluster_name/services/STORM/components does NOT return SUPERVISOR
> Note that Ambari Server shows an ERROR when loading these service components, but the server continues the startup sequence.
> Ambari Web is even usable and you can login, but the YARN and STORM service summary panels show invalid info (and other operations fail, since the server thinks these service components don't even exist).
> Ambari DB consistency should be check during ambari-server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 7ea96be
> version 6a4bfb9
>
> Diff: https://reviews.apache.org/r/32981/diff/
>
>
> Testing
> -------
>
> manual tests on corrupted DB's
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 32981: Some service components are missing from API
response and causes problems
Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32981/#review79418
-----------------------------------------------------------
Ship it!
Ship It!
- Sid Wagle
On April 8, 2015, 7:50 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32981/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 7:50 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
>
>
> Bugs: AMBARI-10405
> https://issues.apache.org/jira/browse/AMBARI-10405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have a situation where service components that have been installed and previously working have disappeared from the API response.
> /api/v1/clusters/cluster_name/services/YARN/components does NOT return NODEMANAGER
> /api/v1/clusters/cluster_name/services/STORM/components does NOT return SUPERVISOR
> Note that Ambari Server shows an ERROR when loading these service components, but the server continues the startup sequence.
> Ambari Web is even usable and you can login, but the YARN and STORM service summary panels show invalid info (and other operations fail, since the server thinks these service components don't even exist).
> Ambari DB consistency should be check during ambari-server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 7ea96be
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 58b94d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 23246b4
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 3a0d3fd
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32981/diff/
>
>
> Testing
> -------
>
> manual tests on corrupted DB's
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 32981: Some service components are missing from API
response and causes problems
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32981/#review79423
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On April 8, 2015, 7:50 p.m., Dmytro Sen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32981/
> -----------------------------------------------------------
>
> (Updated April 8, 2015, 7:50 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Sid Wagle.
>
>
> Bugs: AMBARI-10405
> https://issues.apache.org/jira/browse/AMBARI-10405
>
>
> Repository: ambari
>
>
> Description
> -------
>
> We have a situation where service components that have been installed and previously working have disappeared from the API response.
> /api/v1/clusters/cluster_name/services/YARN/components does NOT return NODEMANAGER
> /api/v1/clusters/cluster_name/services/STORM/components does NOT return SUPERVISOR
> Note that Ambari Server shows an ERROR when loading these service components, but the server continues the startup sequence.
> Ambari Web is even usable and you can login, but the YARN and STORM service summary panels show invalid info (and other operations fail, since the server thinks these service components don't even exist).
> Ambari DB consistency should be check during ambari-server start
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 7ea96be
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 58b94d8
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java PRE-CREATION
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 23246b4
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 3a0d3fd
> ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/32981/diff/
>
>
> Testing
> -------
>
> manual tests on corrupted DB's
>
>
> Thanks,
>
> Dmytro Sen
>
>
Re: Review Request 32981: Some service components are missing from API
response and causes problems
Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32981/
-----------------------------------------------------------
(Updated Апрель 8, 2015, 7:50 п.п.)
Review request for Ambari, Alejandro Fernandez and Sid Wagle.
Bugs: AMBARI-10405
https://issues.apache.org/jira/browse/AMBARI-10405
Repository: ambari
Description
-------
We have a situation where service components that have been installed and previously working have disappeared from the API response.
/api/v1/clusters/cluster_name/services/YARN/components does NOT return NODEMANAGER
/api/v1/clusters/cluster_name/services/STORM/components does NOT return SUPERVISOR
Note that Ambari Server shows an ERROR when loading these service components, but the server continues the startup sequence.
Ambari Web is even usable and you can login, but the YARN and STORM service summary panels show invalid info (and other operations fail, since the server thinks these service components don't even exist).
Ambari DB consistency should be check during ambari-server start
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 7ea96be
ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java 58b94d8
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/DatabaseChecker.java PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java 23246b4
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariServerTest.java 3a0d3fd
ambari-server/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/32981/diff/
Testing
-------
manual tests on corrupted DB's
Thanks,
Dmytro Sen