[jira] [Commented] (NIFI-5718) Performance degraded in ReplaceText processor

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678325#comment-16678325 ] 

ASF GitHub Bot commented on NIFI-5718:
--------------------------------------

Github user patricker commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/3100#discussion_r231534519
  
    --- Diff: nifi-commons/nifi-utils/src/main/java/org/apache/nifi/stream/io/RepeatingInputStream.java ---
    @@ -0,0 +1,103 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.nifi.stream.io;
    +
    +import java.io.ByteArrayInputStream;
    +import java.io.IOException;
    +import java.io.InputStream;
    +import java.util.Objects;
    +
    +public class RepeatingInputStream extends InputStream {
    --- End diff --
    
    @markap14 Thoughts?


> Performance degraded in ReplaceText processor
> ---------------------------------------------
>
>                 Key: NIFI-5718
>                 URL: https://issues.apache.org/jira/browse/NIFI-5718
>             Project: Apache NiFi
>          Issue Type: Bug
>    Affects Versions: 1.8.0
>            Reporter: Mark Payne
>            Assignee: Mark Payne
>            Priority: Major
>         Attachments: Screen Shot 2018-10-17 at 10.55.53 AM.png
>
>
> NIFI-5711 addresses some licensing concerns in the NLKBufferedReader class.
> In doing so, however, it results in lower performance. The ReplaceText processor is affected if the Evaluation Mode is set to Line-by-Line, and the RouteText processor will also be affected. We should be able to match the performance of the previous version.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)