You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Ji Liu (JIRA)" <ji...@apache.org> on 2019/04/08 10:41:00 UTC

[jira] [Comment Edited] (FLINK-7916) Remove NetworkStackThroughputITCase

    [ https://issues.apache.org/jira/browse/FLINK-7916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16812155#comment-16812155 ] 

Ji Liu edited comment on FLINK-7916 at 4/8/19 10:40 AM:
--------------------------------------------------------

Agree, I think move these tests to _org.apache.flink.test.manual_ under _flink-tests_ is a good idea. Is this still open?[~till.rohrmann]


was (Author: tianchen92):
Agree, I think move these tests to _org.apache.flink.test.manual_ under _flink-tests_ is a good idea.

> Remove NetworkStackThroughputITCase
> -----------------------------------
>
>                 Key: FLINK-7916
>                 URL: https://issues.apache.org/jira/browse/FLINK-7916
>             Project: Flink
>          Issue Type: Task
>          Components: Runtime / Network, Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Priority: Major
>
> Flink's code base contains the {{NetworkStackThroughputITCase}} which is not really a test. Moreover it is marked as {{Ignored}}. I propose to remove this test because it is more of a benchmark. We could think about creating a benchmark project where we move these kind of "tests".
> In general I think we should remove ignored tests if they won't be fixed immediately. The danger is far too high that we forget about them and then we only keep the maintenance burden of it. This is especially true for the above mentioned test case.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)