You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/08/25 23:52:10 UTC
[GitHub] [pulsar] vzhikserg commented on a change in pull request #4989: Add
checkstyle validation and fix style violations in the common module
vzhikserg commented on a change in pull request #4989: Add checkstyle validation and fix style violations in the common module
URL: https://github.com/apache/pulsar/pull/4989#discussion_r317420372
##########
File path: pulsar-common/src/main/java/org/apache/pulsar/common/api/raw/RawMessageId.java
##########
@@ -18,6 +18,7 @@
*/
package org.apache.pulsar.common.api.raw;
+@SuppressWarnings("checkstyle:JavadocType")
Review comment:
No particular reason, but writing javadoc comments takes a considerable amount of time. The problem was that this module had a lot of violations (appx. 600) and it was hard to fix all of them at once. I fixed most of the suppressed warnings related to missing javadoc comments. In some cases, I could not find fitting descriptions and I left the suppressed warnings.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services