You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2019/12/30 16:05:50 UTC

[GitHub] [drill] KazydubB commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column

KazydubB commented on a change in pull request #1941: DRILL-7495: Excel Reader Not Parsing Dates Correctly in First Column
URL: https://github.com/apache/drill/pull/1941#discussion_r362025701
 
 

 ##########
 File path: contrib/format-excel/src/main/java/org/apache/drill/exec/store/excel/ExcelBatchReader.java
 ##########
 @@ -412,7 +413,7 @@ private void addColumnToArray(TupleWriter rowWriter, String name, TypeProtos.Min
 
   /**
    * Returns the index of the first row of actual data.  This function is to be used to find the header row as the POI skips blank rows.
-   * @return:  The headerRow index, corrected for blank rows
+   * @return int The headerRow index, corrected for blank rows
 
 Review comment:
   nit: there is no need to specify return type in `@return`, it looks awkward a little bit.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services