You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Ted Yu (JIRA)" <ji...@apache.org> on 2016/08/08 21:04:20 UTC

[jira] [Updated] (HBASE-16377) ServerName check is ineffective in region_mover.rb

     [ https://issues.apache.org/jira/browse/HBASE-16377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-16377:
---------------------------
    Description: 
The following was observed during test of region_mover.rb :
{code}
2016-08-08 11:17:05,341|beaver.machine|INFO|352|139926954637120|MainThread|2016-08-08 11:17:05,340 INFO  [RubyThread-9: hbase-client/bin/thread-pool.rb:28] region_mover: Moving region  hbase:meta,,1.1588230740 (1 of 14) from xYz.openstacklocal,16020,1470654716593, to server=xYz.openstacklocal,16020,1470654716593
{code}
There is check that target server should not be the same as current server:
{code}
    if currentServer and currentServer == servername
      $LOG.info("Region " + r.getRegionNameAsString() + " (" + counter.to_s +
        " of " + regions.length.to_s + ") already on target server=" + servername)
      counter = counter + 1
      next
    end
{code}
However, the check is not effective.
See comparison between object1 and object3:
http://www.skorks.com/2009/09/ruby-equality-and-object-comparison/

  was:
The following was observed during test of region_mover.rb :
{code}
2016-08-08 11:17:05,341|beaver.machine|INFO|352|139926954637120|MainThread|2016-08-08 11:17:05,340 INFO  [RubyThread-9: /usr/hdp/current/hbase-client/bin/thread-pool.rb:28] region_mover: Moving region  hbase:meta,,1.1588230740 (1 of 14) from xYz.openstacklocal,16020,1470654716593, to server=xYz.openstacklocal,16020,1470654716593
{code}
There is check that target server should not be the same as current server:
{code}
    if currentServer and currentServer == servername
      $LOG.info("Region " + r.getRegionNameAsString() + " (" + counter.to_s +
        " of " + regions.length.to_s + ") already on target server=" + servername)
      counter = counter + 1
      next
    end
{code}
However, the check is not effective.
See comparison between object1 and object3:
http://www.skorks.com/2009/09/ruby-equality-and-object-comparison/


> ServerName check is ineffective in region_mover.rb
> --------------------------------------------------
>
>                 Key: HBASE-16377
>                 URL: https://issues.apache.org/jira/browse/HBASE-16377
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 1.1.2
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>
> The following was observed during test of region_mover.rb :
> {code}
> 2016-08-08 11:17:05,341|beaver.machine|INFO|352|139926954637120|MainThread|2016-08-08 11:17:05,340 INFO  [RubyThread-9: hbase-client/bin/thread-pool.rb:28] region_mover: Moving region  hbase:meta,,1.1588230740 (1 of 14) from xYz.openstacklocal,16020,1470654716593, to server=xYz.openstacklocal,16020,1470654716593
> {code}
> There is check that target server should not be the same as current server:
> {code}
>     if currentServer and currentServer == servername
>       $LOG.info("Region " + r.getRegionNameAsString() + " (" + counter.to_s +
>         " of " + regions.length.to_s + ") already on target server=" + servername)
>       counter = counter + 1
>       next
>     end
> {code}
> However, the check is not effective.
> See comparison between object1 and object3:
> http://www.skorks.com/2009/09/ruby-equality-and-object-comparison/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)