You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ambari.apache.org by ja...@apache.org on 2014/05/29 01:09:26 UTC

git commit: AMBARI-5919. Ambari views: List of view instances always remains empty on ui. (jaimin)

Repository: ambari
Updated Branches:
  refs/heads/trunk c36bbc564 -> 00135dff9


AMBARI-5919. Ambari views: List of view instances always remains empty on ui. (jaimin)


Project: http://git-wip-us.apache.org/repos/asf/ambari/repo
Commit: http://git-wip-us.apache.org/repos/asf/ambari/commit/00135dff
Tree: http://git-wip-us.apache.org/repos/asf/ambari/tree/00135dff
Diff: http://git-wip-us.apache.org/repos/asf/ambari/diff/00135dff

Branch: refs/heads/trunk
Commit: 00135dff92e0402a77c48420621a2d49276e8970
Parents: c36bbc5
Author: Jaimin Jetly <ja...@hortonworks.com>
Authored: Wed May 28 16:09:00 2014 -0700
Committer: Jaimin Jetly <ja...@hortonworks.com>
Committed: Wed May 28 16:09:13 2014 -0700

----------------------------------------------------------------------
 ambari-web/app/controllers/global/cluster_controller.js | 3 +--
 ambari-web/app/views/main/menu.js                       | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/ambari/blob/00135dff/ambari-web/app/controllers/global/cluster_controller.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/controllers/global/cluster_controller.js b/ambari-web/app/controllers/global/cluster_controller.js
index 8d0dcf5..dff0f57 100644
--- a/ambari-web/app/controllers/global/cluster_controller.js
+++ b/ambari-web/app/controllers/global/cluster_controller.js
@@ -417,7 +417,6 @@ App.ClusterController = Em.Controller.extend({
   },
 
   loadViewInstancesSuccess: function (data) {
-    var self = this;
     data.versions.forEach(function (version) {
       version.instances.forEach(function (instance) {
         var view = Em.Object.create({
@@ -427,7 +426,7 @@ App.ClusterController = Em.Controller.extend({
           version: version.ViewVersionInfo.version,
           href: "/views/" + instance.ViewInstanceInfo.view_name + "/" + version.ViewVersionInfo.version + "/" + instance.ViewInstanceInfo.instance_name
         });
-        self.get('ambariViews').push(view);
+        this.get('ambariViews').pushObject(view);
       }, this);
     }, this);
   },

http://git-wip-us.apache.org/repos/asf/ambari/blob/00135dff/ambari-web/app/views/main/menu.js
----------------------------------------------------------------------
diff --git a/ambari-web/app/views/main/menu.js b/ambari-web/app/views/main/menu.js
index 27621af..e17f3f5 100644
--- a/ambari-web/app/views/main/menu.js
+++ b/ambari-web/app/views/main/menu.js
@@ -28,7 +28,7 @@ App.MainMenuView = Em.CollectionView.extend({
 
   views: function() {
     return App.router.get('clusterController.ambariViews');
-  }.property('App.ClusterController.ambariViews'),
+  }.property('App.router.clusterController.ambariViews'),
 
   content:function(){
     var result = [];