You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/05/29 12:32:48 UTC
[GitHub] [incubator-inlong] healchow opened a new pull request, #4420: [INLONG-4419][Manager] The manager-client module reuses the sink classes in manager-common
healchow opened a new pull request, #4420:
URL: https://github.com/apache/incubator-inlong/pull/4420
### Title Name: [INLONG-4419][Manager] The manager-client module reuses the sink classes in manager-common
Fixes #4419
### Motivation
The manager-client module reuses the sink classes in manager-common, to reduce maintenance costs for duplicate code.
### Modifications
1. Remove all classes in the sink package of the manager-client module.
2. Reuse the sink classes in the manager-common module.
3. Use the SinkField class instead SinkFieldRequest and SinkFieldResponse classes.
### Verifying this change
- [X] This change is a trivial rework/code cleanup without any test coverage.
### Documentation
- Does this pull request introduces a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] woofyzhao commented on a diff in pull request #4420: [INLONG-4419][Manager] The manager-client module reuses the sink classes in manager-common
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #4420:
URL: https://github.com/apache/incubator-inlong/pull/4420#discussion_r884275298
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/FieldRelationShipUtils.java:
##########
@@ -102,13 +102,12 @@ private static List<FieldRelationShip> createFieldRelationShips(List<StreamField
private static List<FieldRelationShip> createJoinerFieldRelationShips(List<StreamField> fieldList,
Review Comment:
Should we also rename the class name and function name to _Relationships_ since they are renamed everywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] woofyzhao commented on a diff in pull request #4420: [INLONG-4419][Manager] The manager-client module reuses the sink classes in manager-common
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #4420:
URL: https://github.com/apache/incubator-inlong/pull/4420#discussion_r884275298
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/FieldRelationShipUtils.java:
##########
@@ -102,13 +102,12 @@ private static List<FieldRelationShip> createFieldRelationShips(List<StreamField
private static List<FieldRelationShip> createJoinerFieldRelationShips(List<StreamField> fieldList,
Review Comment:
Should we also rename the class name and function name to _Relationships_ since they are renamed everywhere else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] woofyzhao commented on a diff in pull request #4420: [INLONG-4419][Manager] The manager-client module reuses the sink classes in manager-common
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #4420:
URL: https://github.com/apache/incubator-inlong/pull/4420#discussion_r884275298
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/FieldRelationShipUtils.java:
##########
@@ -102,13 +102,12 @@ private static List<FieldRelationShip> createFieldRelationShips(List<StreamField
private static List<FieldRelationShip> createJoinerFieldRelationShips(List<StreamField> fieldList,
Review Comment:
should we also rename the class name and function name ?
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/FieldRelationShipUtils.java:
##########
@@ -102,13 +102,12 @@ private static List<FieldRelationShip> createFieldRelationShips(List<StreamField
private static List<FieldRelationShip> createJoinerFieldRelationShips(List<StreamField> fieldList,
Review Comment:
Should we also rename the class name and function name ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] woofyzhao commented on a diff in pull request #4420: [INLONG-4419][Manager] The manager-client module reuses the sink classes in manager-common
Posted by GitBox <gi...@apache.org>.
woofyzhao commented on code in PR #4420:
URL: https://github.com/apache/incubator-inlong/pull/4420#discussion_r884275298
##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/sort/util/FieldRelationShipUtils.java:
##########
@@ -102,13 +102,12 @@ private static List<FieldRelationShip> createFieldRelationShips(List<StreamField
private static List<FieldRelationShip> createJoinerFieldRelationShips(List<StreamField> fieldList,
Review Comment:
Should we also rename the class name and function name to _Relationships_?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-inlong] dockerzhang merged pull request #4420: [INLONG-4419][Manager] The manager-client module reuses the sink classes in manager-common
Posted by GitBox <gi...@apache.org>.
dockerzhang merged PR #4420:
URL: https://github.com/apache/incubator-inlong/pull/4420
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org