You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Yu Zhao <cc...@gmail.com> on 2013/12/03 16:14:38 UTC

Review Request 15965: Show partition command doesn't support db.table

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15965/
-----------------------------------------------------------

Review request for hive.


Repository: hive-git


Description
-------

{code}
hive (default)> show partitions log.history;
FAILED: ParseException line 1:19 missing EOF at '.' near 'log'
{code}

This command doesn't work when we use db.tablename as tablename in its parameter.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 2343a2c 
  ql/src/test/queries/clientpositive/show_partitions.q 7fa7b82 
  ql/src/test/results/clientpositive/show_partitions.q.out 0b0a97a 
  ql/src/test/results/clientpositive/showparts.q.out fccd131 

Diff: https://reviews.apache.org/r/15965/diff/


Testing
-------


Thanks,

Yu Zhao


Re: Review Request 15965: Show partition command doesn't support db.table

Posted by Yu Zhao <cc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15965/
-----------------------------------------------------------

(Updated Dec. 3, 2013, 4:09 p.m.)


Review request for hive.


Bugs: HIVE-5912
    https://issues.apache.org/jira/browse/HIVE-5912


Repository: hive-git


Description
-------

{code}
hive (default)> show partitions log.history;
FAILED: ParseException line 1:19 missing EOF at '.' near 'log'
{code}

This command doesn't work when we use db.tablename as tablename in its parameter.


Diffs
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 2343a2c 
  ql/src/test/queries/clientpositive/show_partitions.q 7fa7b82 
  ql/src/test/results/clientpositive/show_partitions.q.out 0b0a97a 
  ql/src/test/results/clientpositive/showparts.q.out fccd131 

Diff: https://reviews.apache.org/r/15965/diff/


Testing
-------


Thanks,

Yu Zhao


Re: Review Request 15965: Show partition command doesn't support db.table

Posted by Yu Zhao <cc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15965/
-----------------------------------------------------------

(Updated Dec. 3, 2013, 4:04 p.m.)


Review request for hive.


Changes
-------

removed the trailing space


Repository: hive-git


Description
-------

{code}
hive (default)> show partitions log.history;
FAILED: ParseException line 1:19 missing EOF at '.' near 'log'
{code}

This command doesn't work when we use db.tablename as tablename in its parameter.


Diffs (updated)
-----

  ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 2343a2c 
  ql/src/test/queries/clientpositive/show_partitions.q 7fa7b82 
  ql/src/test/results/clientpositive/show_partitions.q.out 0b0a97a 
  ql/src/test/results/clientpositive/showparts.q.out fccd131 

Diff: https://reviews.apache.org/r/15965/diff/


Testing
-------


Thanks,

Yu Zhao


Re: Review Request 15965: Show partition command doesn't support db.table

Posted by Xuefu Zhang <xz...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15965/#review29657
-----------------------------------------------------------



ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
<https://reviews.apache.org/r/15965/#comment57068>

    Please remove the trailing space


Patch looks good. However, please fill out the fields of the review request, such as bug number branch. The topic should  start with the bug number also. Please find other review request as an example.

- Xuefu Zhang


On Dec. 3, 2013, 3:14 p.m., Yu Zhao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15965/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2013, 3:14 p.m.)
> 
> 
> Review request for hive.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> {code}
> hive (default)> show partitions log.history;
> FAILED: ParseException line 1:19 missing EOF at '.' near 'log'
> {code}
> 
> This command doesn't work when we use db.tablename as tablename in its parameter.
> 
> 
> Diffs
> -----
> 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 2343a2c 
>   ql/src/test/queries/clientpositive/show_partitions.q 7fa7b82 
>   ql/src/test/results/clientpositive/show_partitions.q.out 0b0a97a 
>   ql/src/test/results/clientpositive/showparts.q.out fccd131 
> 
> Diff: https://reviews.apache.org/r/15965/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Yu Zhao
> 
>