You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/04/08 05:22:43 UTC
Re: Review Request: Added 'unschedule' operation to the GarbageCollector,
changed schedule to discard the future when unscheduled/rescheduled,
added GarbageCollector unit tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10028/#review18765
-----------------------------------------------------------
src/slave/gc.cpp
<https://reviews.apache.org/r/10028/#comment39175>
Should this be a CHECK?
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/10028/#comment39176>
EXPECT_DISPATCH and EXPECT_MESSAGE (and triggers) have been deprecated, as of last week.
Please rebase of trunk and use FUTURE_DISPATCH.
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/10028/#comment39177>
A Clock::settle() would ensure that GarbageCollectorProcess::schedule will be finished. No need for introducing sleep.
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/10028/#comment39178>
Why not just call gc.unschedule directly here instead of having the temp variables?
src/tests/gc_tests.cpp
<https://reviews.apache.org/r/10028/#comment39179>
ditto
- Vinod Kone
On March 30, 2013, 10:04 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10028/
> -----------------------------------------------------------
>
> (Updated March 30, 2013, 10:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. This was needed in order to write a fix for MESOS-396.
>
>
> This addresses bug MESOS-396.
> https://issues.apache.org/jira/browse/MESOS-396
>
>
> Diffs
> -----
>
> src/slave/gc.hpp 605957c686efd8e50ee5dfd61de51e192d34ac92
> src/slave/gc.cpp c40f42a78457318a7968a6d50bb06632f289db05
> src/tests/gc_tests.cpp 037fe096179596a6bb9359b4258c2afafee300f9
>
> Diff: https://reviews.apache.org/r/10028/diff/
>
>
> Testing
> -------
>
> Added missing and new unit tests.
>
> Also ran the tests with 300 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added 'unschedule' operation to the GarbageCollector,
changed schedule to discard the future when unscheduled/rescheduled,
added GarbageCollector unit tests.
Posted by Ben Mahler <be...@gmail.com>.
> On April 8, 2013, 3:22 a.m., Vinod Kone wrote:
> > src/slave/gc.cpp, lines 96-98
> > <https://reviews.apache.org/r/10028/diff/4/?file=276528#file276528line96>
> >
> > Should this be a CHECK?
This is the false case, when the GCProcess doesn't know about the path.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10028/#review18765
-----------------------------------------------------------
On March 30, 2013, 10:04 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10028/
> -----------------------------------------------------------
>
> (Updated March 30, 2013, 10:04 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. This was needed in order to write a fix for MESOS-396.
>
>
> This addresses bug MESOS-396.
> https://issues.apache.org/jira/browse/MESOS-396
>
>
> Diffs
> -----
>
> src/slave/gc.hpp 605957c686efd8e50ee5dfd61de51e192d34ac92
> src/slave/gc.cpp c40f42a78457318a7968a6d50bb06632f289db05
> src/tests/gc_tests.cpp 037fe096179596a6bb9359b4258c2afafee300f9
>
> Diff: https://reviews.apache.org/r/10028/diff/
>
>
> Testing
> -------
>
> Added missing and new unit tests.
>
> Also ran the tests with 300 iterations.
>
>
> Thanks,
>
> Ben Mahler
>
>