You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Joris van Lieshout <jv...@schubergphilis.com> on 2014/05/21 17:05:25 UTC
Review Request 21771: Cosmetic fixes in cloud-early-config script
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21771/
-----------------------------------------------------------
Review request for cloudstack, Chiradeep Vittal, daan Hoogland, Rajesh Battala, Hugo Trippaers, and Sheng Yang.
Repository: cloudstack-git
Description
-------
1. On start hv_kvp_daemon if it exists. Currently trows an error on the console during boot.
2. By adding -f to the rm of boot_up_done it will be silent if it does not exist. Currently also trows an error during bootup.
3. Use log_action_msg instead of log_action_begin_msg will make the console look cleaner.
Diffs
-----
systemvm/patches/debian/config/etc/init.d/cloud-early-config ffb23ec
Diff: https://reviews.apache.org/r/21771/diff/
Testing
-------
We are running these fixes in our beta and prod env for a while allready
Thanks,
Joris van Lieshout
Re: Review Request 21771: Cosmetic fixes in cloud-early-config script
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21771/#review45492
-----------------------------------------------------------
Ship it!
66816827cbef1415dddd3f734e494c8adc41fbae
- daan Hoogland
On May 21, 2014, 3:05 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21771/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 3:05 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, Rajesh Battala, Hugo Trippaers, and Sheng Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. On start hv_kvp_daemon if it exists. Currently trows an error on the console during boot.
> 2. By adding -f to the rm of boot_up_done it will be silent if it does not exist. Currently also trows an error during bootup.
> 3. Use log_action_msg instead of log_action_begin_msg will make the console look cleaner.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud-early-config ffb23ec
>
> Diff: https://reviews.apache.org/r/21771/diff/
>
>
> Testing
> -------
>
> We are running these fixes in our beta and prod env for a while allready
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21771: Cosmetic fixes in cloud-early-config script
Posted by daan Hoogland <da...@gmail.com>.
> On June 10, 2014, 1:49 p.m., daan Hoogland wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud-early-config, line 39
> > <https://reviews.apache.org/r/21771/diff/1/?file=586596#file586596line39>
> >
> > wouldn't 2>/dev/null be more appropriate for the described objective?
after off-line discussion with Joris I will apply
- daan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21771/#review45229
-----------------------------------------------------------
On May 21, 2014, 3:05 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21771/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 3:05 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, Rajesh Battala, Hugo Trippaers, and Sheng Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. On start hv_kvp_daemon if it exists. Currently trows an error on the console during boot.
> 2. By adding -f to the rm of boot_up_done it will be silent if it does not exist. Currently also trows an error during bootup.
> 3. Use log_action_msg instead of log_action_begin_msg will make the console look cleaner.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud-early-config ffb23ec
>
> Diff: https://reviews.apache.org/r/21771/diff/
>
>
> Testing
> -------
>
> We are running these fixes in our beta and prod env for a while allready
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21771: Cosmetic fixes in cloud-early-config script
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21771/#review45229
-----------------------------------------------------------
systemvm/patches/debian/config/etc/init.d/cloud-early-config
<https://reviews.apache.org/r/21771/#comment79956>
wouldn't 2>/dev/null be more appropriate for the described objective?
- daan Hoogland
On May 21, 2014, 3:05 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21771/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 3:05 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, Rajesh Battala, Hugo Trippaers, and Sheng Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. On start hv_kvp_daemon if it exists. Currently trows an error on the console during boot.
> 2. By adding -f to the rm of boot_up_done it will be silent if it does not exist. Currently also trows an error during bootup.
> 3. Use log_action_msg instead of log_action_begin_msg will make the console look cleaner.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud-early-config ffb23ec
>
> Diff: https://reviews.apache.org/r/21771/diff/
>
>
> Testing
> -------
>
> We are running these fixes in our beta and prod env for a while allready
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21771: Cosmetic fixes in cloud-early-config script
Posted by Joris van Lieshout <jv...@schubergphilis.com>.
> On June 12, 2014, 1:11 p.m., Rajesh Battala wrote:
> > systemvm/patches/debian/config/etc/init.d/cloud-early-config, line 33
> > <https://reviews.apache.org/r/21771/diff/1/?file=586596#file586596line33>
> >
> > This daemon will be installed in the base image itself.
Hi Rajesh, I don't know what you mean by this comment? This daemon is for hyperV only, correct? So, on other hypervisors it does not exist making this a nice way to suppress the message that the script cannot be found, right?
- Joris
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21771/#review45493
-----------------------------------------------------------
On May 21, 2014, 3:05 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21771/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 3:05 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, Rajesh Battala, Hugo Trippaers, and Sheng Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. On start hv_kvp_daemon if it exists. Currently trows an error on the console during boot.
> 2. By adding -f to the rm of boot_up_done it will be silent if it does not exist. Currently also trows an error during bootup.
> 3. Use log_action_msg instead of log_action_begin_msg will make the console look cleaner.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud-early-config ffb23ec
>
> Diff: https://reviews.apache.org/r/21771/diff/
>
>
> Testing
> -------
>
> We are running these fixes in our beta and prod env for a while allready
>
>
> Thanks,
>
> Joris van Lieshout
>
>
Re: Review Request 21771: Cosmetic fixes in cloud-early-config script
Posted by Rajesh Battala <ra...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21771/#review45493
-----------------------------------------------------------
systemvm/patches/debian/config/etc/init.d/cloud-early-config
<https://reviews.apache.org/r/21771/#comment80341>
This daemon will be installed in the base image itself.
- Rajesh Battala
On May 21, 2014, 3:05 p.m., Joris van Lieshout wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21771/
> -----------------------------------------------------------
>
> (Updated May 21, 2014, 3:05 p.m.)
>
>
> Review request for cloudstack, Chiradeep Vittal, daan Hoogland, Rajesh Battala, Hugo Trippaers, and Sheng Yang.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> 1. On start hv_kvp_daemon if it exists. Currently trows an error on the console during boot.
> 2. By adding -f to the rm of boot_up_done it will be silent if it does not exist. Currently also trows an error during bootup.
> 3. Use log_action_msg instead of log_action_begin_msg will make the console look cleaner.
>
>
> Diffs
> -----
>
> systemvm/patches/debian/config/etc/init.d/cloud-early-config ffb23ec
>
> Diff: https://reviews.apache.org/r/21771/diff/
>
>
> Testing
> -------
>
> We are running these fixes in our beta and prod env for a while allready
>
>
> Thanks,
>
> Joris van Lieshout
>
>