You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/04 02:50:36 UTC

[GitHub] [iotdb] lancelly commented on a diff in pull request #6840: [IOTDB-3695]Implememtation of having clause

lancelly commented on code in PR #6840:
URL: https://github.com/apache/iotdb/pull/6840#discussion_r937300627


##########
server/src/main/java/org/apache/iotdb/db/mpp/plan/expression/multi/FunctionExpression.java:
##########
@@ -512,6 +512,7 @@ private UDFQueryTransformer constructUdfTransformer(
 
   @Override
   public boolean isMappable(TypeProvider typeProvider) {
+    if (isBuiltInAggregationFunctionExpression) return true;

Review Comment:
   ```suggestion
       // For calculating nested expressions of BuiltinAggregationFunction
       if (isBuiltInAggregationFunctionExpression) {return true};
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org