You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "stillalex (via GitHub)" <gi...@apache.org> on 2023/05/24 21:07:14 UTC
[GitHub] [solr] stillalex opened a new pull request, #1664: SOLR-16799 upgrade Solr to use Lucene 9.6.0
stillalex opened a new pull request, #1664:
URL: https://github.com/apache/solr/pull/1664
https://issues.apache.org/jira/browse/SOLR-16799
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Lucene 9.6.0 upgrade. There are a lot of failures currently, pushing this to collect some ideas on how to approach this upgrade.
# Solution
Please provide a short description of the approach taken to implement your solution.
# Tests
Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe merged pull request #1664: SOLR-16799 upgrade Solr to use Lucene 9.6.0
Posted by "tflobbe (via GitHub)" <gi...@apache.org>.
tflobbe merged PR #1664:
URL: https://github.com/apache/solr/pull/1664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on a diff in pull request #1664: SOLR-16799 upgrade Solr to use Lucene 9.6.0
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on code in PR #1664:
URL: https://github.com/apache/solr/pull/1664#discussion_r1222252450
##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -539,6 +541,21 @@ public Reader readerValue() {
public Number numericValue() {
return null;
}
+
+ @Override
+ public StoredValue storedValue() {
+ if (fieldType().stored() == false) {
+ return null;
+ } else {
+ return new StoredValue(stringValue());
+ }
+ }
+
+ @Override
+ public InvertableType invertableType() {
+ // TODO SOLR-16799 when to use InvertableType.TOKEN_STREAM and when to use null?
+ return null;
+ }
Review Comment:
hmm. I agree, will remove the TODO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on a diff in pull request #1664: SOLR-16799 upgrade Solr to use Lucene 9.6.0
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on code in PR #1664:
URL: https://github.com/apache/solr/pull/1664#discussion_r1222251980
##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -539,6 +541,21 @@ public Reader readerValue() {
public Number numericValue() {
return null;
}
+
+ @Override
+ public StoredValue storedValue() {
+ if (fieldType().stored() == false) {
+ return null;
+ } else {
+ return new StoredValue(stringValue());
+ }
Review Comment:
I think you are correct. will remove the if block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1664: SOLR-16799 upgrade Solr to use Lucene 9.6.0
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on PR #1664:
URL: https://github.com/apache/solr/pull/1664#issuecomment-1581607366
thank you for talking a look @tflobbe! I updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe commented on pull request #1664: SOLR-16799 upgrade Solr to use Lucene 9.6.0
Posted by "tflobbe (via GitHub)" <gi...@apache.org>.
tflobbe commented on PR #1664:
URL: https://github.com/apache/solr/pull/1664#issuecomment-1584865489
@stillalex, would you add a CHANGES entry for 9.3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] tflobbe commented on a diff in pull request #1664: SOLR-16799 upgrade Solr to use Lucene 9.6.0
Posted by "tflobbe (via GitHub)" <gi...@apache.org>.
tflobbe commented on code in PR #1664:
URL: https://github.com/apache/solr/pull/1664#discussion_r1222196865
##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -539,6 +541,21 @@ public Reader readerValue() {
public Number numericValue() {
return null;
}
+
+ @Override
+ public StoredValue storedValue() {
+ if (fieldType().stored() == false) {
+ return null;
+ } else {
+ return new StoredValue(stringValue());
+ }
+ }
+
+ @Override
+ public InvertableType invertableType() {
+ // TODO SOLR-16799 when to use InvertableType.TOKEN_STREAM and when to use null?
+ return null;
+ }
Review Comment:
It shouldn't matter, right? this is only for stored field retrieval, not for indexing. This should never be called AFAIK
##########
solr/core/src/java/org/apache/solr/search/SolrDocumentFetcher.java:
##########
@@ -539,6 +541,21 @@ public Reader readerValue() {
public Number numericValue() {
return null;
}
+
+ @Override
+ public StoredValue storedValue() {
+ if (fieldType().stored() == false) {
+ return null;
+ } else {
+ return new StoredValue(stringValue());
+ }
Review Comment:
I guess `fieldType().stored()` will never be `false` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] stillalex commented on pull request #1664: SOLR-16799 upgrade Solr to use Lucene 9.6.0
Posted by "stillalex (via GitHub)" <gi...@apache.org>.
stillalex commented on PR #1664:
URL: https://github.com/apache/solr/pull/1664#issuecomment-1585042217
sorry for the delay @tflobbe! pushed a changes.txt update. I rebased too, running the tests again on my local just for good measure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org