You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/03/16 06:19:33 UTC
[GitHub] zeppelin pull request #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable...
GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2144
[ZEPPELIN-2267] Improve Helium Enable / Disable Dialogs
### What is this PR for?
Improved Helium Enable / Disable Dialogs to
- include more detailed info for enable dialog
- include more concise info for disable dialog
- use dialog title as well just instead of message
- link to doc if `type === SPELL || type === VISUALIZATION`
- parse `description` and `license` as HTML
I attached screenshots for comparison.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2267](https://issues.apache.org/jira/browse/ZEPPELIN-2267)
### How should this be tested?
1. Test with local, online helium packages.
2. In case of local package modify description and license text to test HTML parsing like
```
"description": "The Ultimate Line Chart for Apache Zeppelin using <a href src=\"https://www.amcharts.com\">amcharts</a>",
"license": "<a href=\"https://www.amcharts.com/licenses/javascript-charts-free-license\">Amcharts License</a>"
```
### Screenshots (if appropriate)
#### Before: enable dialog
<img width="631" alt="enable_local" src="https://cloud.githubusercontent.com/assets/4968473/23984205/a45babf6-0a5b-11e7-934d-83d6ed31c5eb.png">
#### After: enable dialog
<img width="631" alt="after_enable_local" src="https://cloud.githubusercontent.com/assets/4968473/23984234/c98335ca-0a5b-11e7-9b72-810fda629635.png">
#### Before: disable dialog
<img width="632" alt="disable_local" src="https://cloud.githubusercontent.com/assets/4968473/23984232/c65ed642-0a5b-11e7-8f67-a4ce2c5378f8.png">
#### After: disable dialog
<img width="647" alt="after_disable" src="https://cloud.githubusercontent.com/assets/4968473/23984226/bb0fcfd0-0a5b-11e7-9afb-2326c2f6b778.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2267/improve-helium-dialog
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2144
----
commit 36c46dd136c9023c42ce753a45bfe2051d323c98
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-16T06:03:25Z
feat: Improve heloium enable dialog
commit 0f02fedb75069adb73a1a131b8511052aa4a8032
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-16T06:11:36Z
feat: Improve helium disable dialog
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable Dialog...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2144
Merge into master if no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable...
Posted by 1ambda <gi...@git.apache.org>.
GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2144
[ZEPPELIN-2267] Improve Helium Enable / Disable Dialogs
### What is this PR for?
Improved Helium Enable / Disable Dialogs to
- include more detailed info for enable dialog
- include more concise info for disable dialog
- use dialog title as well just instead of message
- link to doc if `type === SPELL || type === VISUALIZATION`
- parse `description` and `license` as HTML
I attached screenshots for comparison.
### What type of PR is it?
[Improvement]
### Todos
NONE
### What is the Jira issue?
[ZEPPELIN-2267](https://issues.apache.org/jira/browse/ZEPPELIN-2267)
### How should this be tested?
1. Test with local, online helium packages.
2. In case of local package modify description and license text to test HTML parsing like
```
"description": "The Ultimate Line Chart for Apache Zeppelin using <a href src=\"https://www.amcharts.com\">amcharts</a>",
"license": "<a href=\"https://www.amcharts.com/licenses/javascript-charts-free-license\">Amcharts License</a>"
```
### Screenshots (if appropriate)
#### Before: enable dialog
<img width="631" alt="enable_local" src="https://cloud.githubusercontent.com/assets/4968473/23984205/a45babf6-0a5b-11e7-934d-83d6ed31c5eb.png">
#### After: enable dialog
<img width="631" alt="after_enable_local" src="https://cloud.githubusercontent.com/assets/4968473/23984234/c98335ca-0a5b-11e7-9b72-810fda629635.png">
#### Before: disable dialog
<img width="632" alt="disable_local" src="https://cloud.githubusercontent.com/assets/4968473/23984232/c65ed642-0a5b-11e7-8f67-a4ce2c5378f8.png">
#### After: disable dialog
<img width="647" alt="after_disable" src="https://cloud.githubusercontent.com/assets/4968473/23984226/bb0fcfd0-0a5b-11e7-9afb-2326c2f6b778.png">
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2267/improve-helium-dialog
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2144.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2144
----
commit 36c46dd136c9023c42ce753a45bfe2051d323c98
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-16T06:03:25Z
feat: Improve heloium enable dialog
commit 0f02fedb75069adb73a1a131b8511052aa4a8032
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-16T06:11:36Z
feat: Improve helium disable dialog
commit 972aae5da7dcb9fb4395637fb79b7fc07df2b9e4
Author: 1ambda <1a...@gmail.com>
Date: 2017-03-16T06:39:36Z
fix: lint errors
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable Dialog...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/2144
@AhyoungRyu I resolved your all comments. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable Dialog...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/2144
Cool improvement!
LGTM and merge master if no further discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/2144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable Dialog...
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2144
Cool! Tested again and it works well as expected. LGTM \U0001f44d
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2144: [ZEPPELIN-2267] Improve Helium Enable / Disable...
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda closed the pull request at:
https://github.com/apache/zeppelin/pull/2144
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---