You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/03/23 19:52:34 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #19341: fix: Null values on Explore filter
michael-s-molina opened a new pull request #19341:
URL: https://github.com/apache/superset/pull/19341
### SUMMARY
Fixes `NULL` values on Explore filter control.
Fixes https://github.com/apache/superset/issues/19264
### BEFORE/AFTER SCREENSHOTS
https://user-images.githubusercontent.com/70410625/159783385-494dc7e1-603e-469a-bf5d-b97bcf8b00cb.mov
https://user-images.githubusercontent.com/70410625/159784037-39dad8e9-1ef8-422f-8bbd-91b413155711.mov
### TESTING INSTRUCTIONS
Check the video for instructions.
### ADDITIONAL INFORMATION
- [x] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sadpandajoe commented on pull request #19341: fix: Null values on Explore filter
Posted by GitBox <gi...@apache.org>.
sadpandajoe commented on pull request #19341:
URL: https://github.com/apache/superset/pull/19341#issuecomment-1076904778
🏷️ preset:2022.11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19341: fix: Null values on Explore filter
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #19341:
URL: https://github.com/apache/superset/pull/19341#issuecomment-1076834636
Tests well! Merging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19341: fix: Null values on Explore filter
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19341:
URL: https://github.com/apache/superset/pull/19341#issuecomment-1076823982
@rusackas Ephemeral environment spinning up at http://54.187.50.69:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #19341: fix: Null values on Explore filter
Posted by GitBox <gi...@apache.org>.
rusackas commented on pull request #19341:
URL: https://github.com/apache/superset/pull/19341#issuecomment-1076821101
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #19341: fix: Null values on Explore filter
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #19341:
URL: https://github.com/apache/superset/pull/19341#issuecomment-1076834923
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] srinify merged pull request #19341: fix: Null values on Explore filter
Posted by GitBox <gi...@apache.org>.
srinify merged pull request #19341:
URL: https://github.com/apache/superset/pull/19341
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org