[jira] [Commented] (DELTASPIKE-1324) @Transactional annotation at method level doesn't override the one at class level any more

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DELTASPIKE-1324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16423665#comment-16423665 ] 

ASF subversion and git services commented on DELTASPIKE-1324:
-------------------------------------------------------------

Commit a360578bd1239985835519c6162ed4f5e9745ee1 in deltaspike's branch refs/heads/deltaspike-1.8.x from [~tandraschko]
[ https://git-wip-us.apache.org/repos/asf?p=deltaspike.git;h=a360578 ]

DELTASPIKE-1324 Ensure that class level is read before method level.

> @Transactional annotation at method level doesn't override the one at class level any more
> ------------------------------------------------------------------------------------------
>
>                 Key: DELTASPIKE-1324
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-1324
>             Project: DeltaSpike
>          Issue Type: Bug
>          Components: Data-Module
>    Affects Versions: 1.8.1
>            Reporter: Jens Berke
>            Assignee: John D. Ament
>            Priority: Major
>             Fix For: 1.9.0
>
>
> Hi. The behaviour of @Transactional has changed with 1.8.1:
> Until version 1.8.0 @Transactional annotations at method level overrode those at the class level. Like this:
> {code:java}
> @Transactional(readOnly = true)
> public class MyClass {
>     public void doSomethingReadOnly()
>     @Transactional
>     public void writeSomething(){code}
> This stopped working with version 1.8.1 because the @Transactional annotation at method level seems to be ignored and the transaction for the method remains read-only. The cause is probably the change introduced with DELTASPIKE-940, where the following method was added to org.apache.deltaspike.jpa.impl.transaction.TransactionStrategyHelper:
> {code:java}
> EntityManagerMetadata createEntityManagerMetadata(InvocationContext context)
> {
>     EntityManagerMetadata metadata = new EntityManagerMetadata();
>     metadata.readFrom(context.getMethod(), beanManager);
>     metadata.readFrom(context.getMethod().getDeclaringClass(), beanManager);
>     return metadata;
> }{code}
> If first reads the data at method level and then at class level, which seems to be the wrong order. Swapping these lines would restore the correct behaviour:
> {code:java}
> metadata.readFrom(context.getMethod().getDeclaringClass(), beanManager);
> metadata.readFrom(context.getMethod(), beanManager);{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)