config/4526: binbuild.sh doesn't fix apxs (a patch is attached!)

[Eli Marmor <ma...@elmar.co.il>]

>Number:         4526
>Category:       config
>Synopsis:       binbuild.sh doesn't fix apxs (a patch is attached!)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    apache
>State:          open
>Class:          sw-bug
>Submitter-Id:   apache
>Arrival-Date:   Fri Jun  4 08:30:00 PDT 1999
>Last-Modified:
>Originator:     marmor@elmar.co.il
>Organization:
apache
>Release:        1.3.6
>Environment:
All
>Description:
When using the APACI's "BinaryDistribution" layout, and/or
binbuild.sh, to build Apache, an "install-bindist.sh" script is
generated, which can be used to fix various files (e.g. apachectl
and httpd.conf) so they will fit the correct directories.
Unfortunately, apxs is not touched, although it had to (its contents
are incorrect for BinaryDistribution layout).

The attached patch resolves this problem. I am not an APACI's expert
so please review it before adopting it. Maybe there is a better way
to do it. In addition, I believe that there are more files which are
not touched by binbuild.sh (i.e. install-bindist.sh) but should be.

The attached diff refers to the 1.3.6 source tree, not to the up-to-
date CVS version. Note: Both of the "[  ]" there, mean "[ \t]" (i.e.
blank or tab), and not a string of blanks. Sorry for the long lines!
>How-To-Repeat:
Just build Apache using binbuild.sh, and then try to install it under
another system in a non-standard directory (this is what binbuild.sh is
for...), and then try to use apxs.
>Fix:
diff -ur apache_1.3.6/src/helpers/binbuild.sh apache_1.3.6.mine/src/helpers/binbuild.sh
--- apache_1.3.6/src/helpers/binbuild.sh        Tue Mar 23 02:41:40 1999
+++ apache_1.3.6.mine/src/helpers/binbuild.sh   Thu May 13 02:40:04 1999
@@ -161,6 +161,7 @@
   echo "fi" && \
   echo "sed -e s%/usr/local/apache%\$SR/% \$SR/conf/httpd.conf.default > \$SR/conf/httpd.conf" && \
   echo "sed -e s%PIDFILE=%PIDFILE=\$SR/% -e s%HTTPD=%HTTPD=\\\"\$SR/% -e \"s%/httpd$%/httpd -d \$SR\\\"%\" bindist/bin/apachectl > \$SR/bin/apachectl" && \
+  echo "sed -e s%/usr/local/apache%\$SR/% -e \"/\\\$CFG_[A-Z_]*DIR[ 	]*=[ 	]*'[^/]/s%'%'\$SR/%\" bindist/bin/apxs > \$SR/bin/apxs" && \
   echo " " && \
   echo "echo \"Ready.\"" && \
   echo "echo \" +--------------------------------------------------------+\"" && \
>Audit-Trail:
>Unformatted:
[In order for any reply to be added to the PR database, you need]
[to include <ap...@Apache.Org> in the Cc line and make sure the]
[subject line starts with the report component and number, with ]
[or without any 'Re:' prefixes (such as "general/1098:" or      ]
["Re: general/1098:").  If the subject doesn't match this       ]
[pattern, your message will be misfiled and ignored.  The       ]
["apbugs" address is not added to the Cc line of messages from  ]
[the database automatically because of the potential for mail   ]
[loops.  If you do not include this Cc, your reply may be ig-   ]
[nored unless you are responding to an explicit request from a  ]
[developer.  Reply only with text; DO NOT SEND ATTACHMENTS!     ]